Date: Fri, 3 Oct 2014 10:03:47 -0400 From: Vedant Mathur <vmathur3@ncsu.edu> To: "Andrey V. Elsukov" <bu7cher@yandex.ru> Cc: freebsd-net@freebsd.org Subject: Re: Addressing refcount issues in ip6_setdstifaddr and ip6_getdstifaddr routines. Message-ID: <CAKeOEPC024A=X4dipe0rJg7gtL0q4b2S-US-45-MttbGQefFjw@mail.gmail.com> In-Reply-To: <542B7D74.4090302@yandex.ru> References: <CAKeOEPB=e-5kdFP7paYgWSwNGtBONM9xCpkis7HhkvU1b9Oavg@mail.gmail.com> <542B7D74.4090302@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Andrey, Not a bad option. I saw you deleted the ip6_findaux routine which is used in route6_input. You have a ifdef around it. Whats that for? -Vedant On Wed, Oct 1, 2014 at 12:05 AM, Andrey V. Elsukov <bu7cher@yandex.ru> wrote: > On 30.09.2014 19:24, Vedant Mathur wrote: > > *Solution 2:* > > > > In ip6_setdstifaddr() routine we can access the struct ifa using > > ia6->ia_ifa and retrieve the IP address from the ifa and then push it > > into the m_tag instead of the struct in6_ifaddr pointer. Then we will > > not require a refcnt increment and in the ip6_getdstifaddr() we can > > use the ifa_withifaddr() routines to retrieve the ia by basically > > looping through the list of ifaddrs. > > > > Hi, > > *Solution 3:* > > Remove this code :) > What you think about this? > https://svnweb.freebsd.org/base?view=revision&revision=256673 > > -- > WBR, Andrey V. Elsukov >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKeOEPC024A=X4dipe0rJg7gtL0q4b2S-US-45-MttbGQefFjw>