From owner-svn-src-all@FreeBSD.ORG  Tue Oct 11 07:45:31 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 032C8106566C;
	Tue, 11 Oct 2011 07:45:31 +0000 (UTC) (envelope-from des@des.no)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
	by mx1.freebsd.org (Postfix) with ESMTP id 8DA1B8FC0A;
	Tue, 11 Oct 2011 07:45:30 +0000 (UTC)
Received: from ds4.des.no (des.no [84.49.246.2])
	by smtp.des.no (Postfix) with ESMTP id 8BBCA1FFC33;
	Tue, 11 Oct 2011 07:45:29 +0000 (UTC)
Received: by ds4.des.no (Postfix, from userid 1001)
	id 4D622846B3; Tue, 11 Oct 2011 09:45:29 +0200 (CEST)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Jaakko Heinonen <jh@FreeBSD.org>
References: <201110081221.p98CLpWq062285@svn.freebsd.org>
	<20111010145642.GA2057@a91-153-123-205.elisa-laajakaista.fi>
Date: Tue, 11 Oct 2011 09:45:29 +0200
In-Reply-To: <20111010145642.GA2057@a91-153-123-205.elisa-laajakaista.fi>
	(Jaakko Heinonen's message of "Mon, 10 Oct 2011 17:56:43 +0300")
Message-ID: <86hb3gj7ja.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r226151 - head/usr.bin/kdump
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Oct 2011 07:45:31 -0000

Jaakko Heinonen <jh@FreeBSD.org> writes:
> Dag-Erling Smorgrav <des@FreeBSD.org> writes:
> > +#define print_number(i,n,c)					\
> > +	do {							\
> > +		if (decimal)					\
> > +			printf("%c%jd", c, (intmax_t)*i);	\
> > +		else						\
> > +			printf("%c%#jx", c, (intmax_t)*i);	\
> > +		i++;						\
> > +		n--;						\
> > +		c =3D ',';					\
> > +	} while (0)
> Are you sure that this change doesn't cause a regression on platforms
> where sizeof(long) !=3D sizeof(intmax_t)?
>
> For example, previously, on i386 print_number() printed "0xffffffff" for
> -1 while after your change it will print "0xffffffffffffffff" (with %#jx).

You are right, the cast for the hex case should be to uintmax_t.  I
think I got all the other instances right...

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no