From owner-cvs-src@FreeBSD.ORG  Tue Apr 26 22:45:06 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6F81B16A4CE; Tue, 26 Apr 2005 22:45:06 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 599A643D46; Tue, 26 Apr 2005 22:45:06 +0000 (GMT)
	(envelope-from davidxu@freebsd.org)
Received: from [127.0.0.1] (davidxu@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j3QMj48t063415;
	Tue, 26 Apr 2005 22:45:05 GMT
	(envelope-from davidxu@freebsd.org)
Message-ID: <426EC46E.8010701@freebsd.org>
Date: Wed, 27 Apr 2005 06:45:02 +0800
From: David Xu <davidxu@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.5) Gecko/20050306
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: John Baldwin <jhb@freebsd.org>
References: <200504190811.j3J8BSdx072259@repoman.freebsd.org>
	<200504261143.58152.jhb@FreeBSD.org>
In-Reply-To: <200504261143.58152.jhb@FreeBSD.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/kern kern_sig.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Apr 2005 22:45:06 -0000

John Baldwin wrote:

>On Tuesday 19 April 2005 04:11 am, David Xu wrote:
>  
>
>>davidxu     2005-04-19 08:11:28 UTC
>>
>>  FreeBSD src repository
>>
>>  Modified files:
>>    sys/kern             kern_sig.c
>>  Log:
>>  Oops, forgot to update this file.
>>  Fix a race condition between kern_wait() and thread_stopped().
>>  Problem is in kern_wait(), parent process steps through children list,
>>  once a child process is skipped, and later even if the child is stopped,
>>  parent process still sleeps in msleep(), the race happens if parent
>>  masked SIGCHLD.
>>
>>  Submitted by : Peter Edwards peadar.edwards at gmail dot com
>>  MFC after    : 4 days
>>    
>>
>
>You're not setting P_STOPPED_SIG anymore, is that on purpose?
>
>  
>
It is already tested in thread_stopped(), original stop() is called after
the test, so there is no different.