From owner-freebsd-current@FreeBSD.ORG Wed Nov 27 12:17:40 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4ACF68E0 for ; Wed, 27 Nov 2013 12:17:40 +0000 (UTC) Received: from mail-yh0-x234.google.com (mail-yh0-x234.google.com [IPv6:2607:f8b0:4002:c01::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 12AE92C24 for ; Wed, 27 Nov 2013 12:17:40 +0000 (UTC) Received: by mail-yh0-f52.google.com with SMTP id i72so4914544yha.39 for ; Wed, 27 Nov 2013 04:17:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:user-agent:in-reply-to:references :mime-version:content-transfer-encoding:content-type; bh=nX1B+A1m/6YE5hYwalyLefo7OROV0vSEsvlgl5CYfV8=; b=YF4YqzJ+l3uG+FumGjMnhletPRiSxTKagXVnosCmvm7K/GcTM4CxC8uztyNeNtBeTz Uc98Lz2nGuaAxDtKe7VC3JJpCEtnWYSYRpWQFugdmK9gI5iLvYBteo4Aof80eVy1C4TT YCQJdju76WQk/W1nfJiePOJa1SF/0T9+yh8FcqIZaYtfzkoS5oq5JLlbx0GOGFkz5+nR l/0frUIXaqb+08s175lBpPrkRr4DNvqdziRwoUtWWyyvPGzbT+ll0LGE2bjSqy8ZKzKz FN9PORetJzKHBsJRkSMu0WPe5dOT4nPuyxytCI2IkaiKAy0ZGxefm13BLZoB3H8rWRoh FwHQ== X-Received: by 10.236.17.133 with SMTP id j5mr1666905yhj.77.1385554658961; Wed, 27 Nov 2013 04:17:38 -0800 (PST) Received: from blackbeast.local (75-120-65-175.dyn.centurytel.net. [75.120.65.175]) by mx.google.com with ESMTPSA id q9sm89306584yhk.16.2013.11.27.04.17.35 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Nov 2013 04:17:36 -0800 (PST) From: Chuck Burns To: freebsd-current@freebsd.org Subject: Re: (bsd)patch vs ports Date: Wed, 27 Nov 2013 06:17:34 -0600 Message-ID: <2069317.7t5sA85o8W@blackbeast.local> User-Agent: KMail/4.10.5 (FreeBSD/10.0-BETA3; KDE/4.10.5; amd64; ; ) In-Reply-To: <5295B9B6.1070400@FreeBSD.org> References: <5295B9B6.1070400@FreeBSD.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Nov 2013 12:17:40 -0000 On Wednesday, November 27, 2013 11:21:58 AM Andriy Gapon wrote: > When building ports on head I sometimes see messages like the following > during a patch phase: > > ===> Applying FreeBSD patches for firefox-25.0_1,1 > No such line 262 in input file, ignoring > ===> Applying NSS patches > No such line 194 in input file, ignoring > No such line 658 in input file, ignoring > No such line 52 in input file, ignoring > No such line 45 in input file, ignoring > > Is this a cause for concern? > Do those messages mean that potentially important patches are not actually > applied? Well.. If it compiles, then no, those patches were probably not important. Security fixes are usually done upstream by the vendor. Honestly, it appears that someone left old patch files, and those patches may no longer be needed for firefox to compile on FreeBSD. break19