From nobody Fri Oct 3 08:32:10 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cdMNC1llQz69vTX; Fri, 03 Oct 2025 08:32:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cdMNC0wP8z432J; Fri, 03 Oct 2025 08:32:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759480331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=K33vwb4k2umwRYytun0jOurc/kqO3bkavWVdLo9VXqc=; b=XNoNO2F5Wx8qmVlDnp9eQusQMt9C9C7IfanSW4KkjqjSCX2eHciuvD+U8IC7PnsX+c+MfT GEHVuGH9OZ7Ayyb+fSyzNvxFHNllNQFCgBkc6iw5UtbiBfhssdX8fAg0OHmAvGWS1VfhuG gGyu6V1c+fTQlSn5SuYzJp3AYq0vVu4ff9jTXjAwg1RpNmZjQR1OsCjx5mAx+uE3la2W3m pfEZkogm4iITltIT+77EHKKToGHAxmjrFeud1PtYbwDv8kgodkiDRQzsf/ajGooDMGuHR+ OFFM7JyIhAKs5Q7AaTH39PMXAZ4vShz4e+sZVTBLpHjajLl80dtP9YL4ji2arw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759480331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=K33vwb4k2umwRYytun0jOurc/kqO3bkavWVdLo9VXqc=; b=OKOAVTJUsnyVUBKoK0/NGdasdPlT1JsJOKFHSzlNMZ+k3hPEOdUH0Ddg6DhQXUqNvBYGqq J/lBhg9DuHL/qImiWM82DG4FrfIXdbS0bdAaGHWTksyJmmdHV0LeIqd3bWwxRpbuv75w8B MO9zdS7At+g0OMSpntUkO/oKfOPO5VnQjp3lg/ME0xhx90GLfSQ/+scO/5aBovy1vwyd+y AKmFF4dPvqmcuWWJjNtzWvqJEYBYKdj5xaxamIR2ecwExC38d9fc/mG2fMATj8/5+uuTca xCsWJjrtwR1vSrp3AZgU8x6s/f2V7JfHEnQGIZN6eobwyUy7VmnrXd561GrxSw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759480331; a=rsa-sha256; cv=none; b=HPMBIvh0wjfX3qZVNj59rq6YNnOoIxXPnRZXNyRiAmwT7AQP3YT2opToDFieYi8b6jesTS hYmXzDiCEO6epC0E4z6hxrOQkV9n/yonweBb7r57paDf5LM5xI5ohEqyqQuvPRM9WhIRul RQW9inOgnVPxtB4+Hp4fvk3Do1NKm7OMjW9IK9G6jUjiFhg+4Ka+NwP/yHvF7NSCVT3Mas xbrmluAxPk7tnZp4d7qgD8es5D1jnGughaRxyi4ui7ycjCgWUgpLD1WNPkVs/Ca4vhDmku fRgBiSLoUS7TwWLvyFCb/7oZEsYjivY6vtunYd0WIyMX/OmTWUidQxWCl1lRcw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cdMNC0Mzzzn1H; Fri, 03 Oct 2025 08:32:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5938WA6D020391; Fri, 3 Oct 2025 08:32:10 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5938WAPA020388; Fri, 3 Oct 2025 08:32:10 GMT (envelope-from git) Date: Fri, 3 Oct 2025 08:32:10 GMT Message-Id: <202510030832.5938WAPA020388@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: c55c8a899edc - stable/14 - tcp: apply rate limits to challenge ACKs List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: c55c8a899edcb5736df46058ac57e8d20f653991 Auto-Submitted: auto-generated The branch stable/14 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=c55c8a899edcb5736df46058ac57e8d20f653991 commit c55c8a899edcb5736df46058ac57e8d20f653991 Author: Michael Tuexen AuthorDate: 2025-09-30 20:06:33 +0000 Commit: Michael Tuexen CommitDate: 2025-10-03 08:31:41 +0000 tcp: apply rate limits to challenge ACKs When sending challenge ACKs from the SYN-cache, apply the same rate limiting as in other states. Reviewed by: cc, rrs Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D52754 (cherry picked from commit c2900b6e8255ba4f54dbd897cf42427db577ed3d) --- sys/netinet/tcp_syncache.c | 28 ++++++++++++++++++++++++---- sys/netinet/tcp_syncache.h | 2 ++ 2 files changed, 26 insertions(+), 4 deletions(-) diff --git a/sys/netinet/tcp_syncache.c b/sys/netinet/tcp_syncache.c index 9d2c5dd5098e..012240f46ffb 100644 --- a/sys/netinet/tcp_syncache.c +++ b/sys/netinet/tcp_syncache.c @@ -130,6 +130,7 @@ static void syncache_drop(struct syncache *, struct syncache_head *); static void syncache_free(struct syncache *); static void syncache_insert(struct syncache *, struct syncache_head *); static int syncache_respond(struct syncache *, const struct mbuf *, int); +static int syncache_send_challenge_ack(struct syncache *, struct mbuf *); static struct socket *syncache_socket(struct syncache *, struct socket *, struct mbuf *m); static void syncache_timeout(struct syncache *sc, struct syncache_head *sch, @@ -702,10 +703,7 @@ syncache_chkrst(struct in_conninfo *inc, struct tcphdr *th, struct mbuf *m, "sending challenge ACK\n", s, __func__, th->th_seq, sc->sc_irs + 1, sc->sc_wnd); - if (syncache_respond(sc, m, TH_ACK) == 0) { - TCPSTAT_INC(tcps_sndacks); - TCPSTAT_INC(tcps_sndtotal); - } else { + if (syncache_send_challenge_ack(sc, m) != 0) { syncache_drop(sc, sch); TCPSTAT_INC(tcps_sc_dropped); } @@ -976,6 +974,10 @@ syncache_socket(struct syncache *sc, struct socket *lso, struct mbuf *m) if (sc->sc_rxmits > 1) tp->snd_cwnd = 1; + /* Copy over the challenge ACK state. */ + tp->t_challenge_ack_end = sc->sc_challenge_ack_end; + tp->t_challenge_ack_cnt = sc->sc_challenge_ack_cnt; + #ifdef TCP_OFFLOAD /* * Allow a TOE driver to install its hooks. Note that we hold the @@ -2060,6 +2062,24 @@ syncache_respond(struct syncache *sc, const struct mbuf *m0, int flags) return (error); } +static int +syncache_send_challenge_ack(struct syncache *sc, struct mbuf *m) +{ + int error; + + if (tcp_challenge_ack_check(&sc->sc_challenge_ack_end, + &sc->sc_challenge_ack_cnt)) { + error = syncache_respond(sc, m, TH_ACK); + if (error == 0) { + TCPSTAT_INC(tcps_sndacks); + TCPSTAT_INC(tcps_sndtotal); + } + } else { + error = 0; + } + return (error); +} + /* * The purpose of syncookies is to handle spoofed SYN flooding DoS attacks * that exceed the capacity of the syncache by avoiding the storage of any diff --git a/sys/netinet/tcp_syncache.h b/sys/netinet/tcp_syncache.h index 219cddee0b1d..9445940bcec5 100644 --- a/sys/netinet/tcp_syncache.h +++ b/sys/netinet/tcp_syncache.h @@ -69,6 +69,8 @@ struct syncache { u_int8_t sc_requested_s_scale:4, sc_requested_r_scale:4; u_int16_t sc_flags; + u_int32_t sc_challenge_ack_cnt; /* chall. ACKs sent in epoch */ + sbintime_t sc_challenge_ack_end; /* End of chall. ack epoch */ #if defined(TCP_OFFLOAD) || !defined(TCP_OFFLOAD_DISABLE) struct toedev *sc_tod; /* entry added by this TOE */ void *sc_todctx; /* TOE driver context */