From owner-freebsd-current  Sun Sep 22  7: 9:18 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id F096B37B401; Sun, 22 Sep 2002 07:09:16 -0700 (PDT)
Received: from smtp0.adl1.internode.on.net (smtp0.adl1.internode.on.net [203.16.214.194])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 254D943E4A; Sun, 22 Sep 2002 07:09:16 -0700 (PDT)
	(envelope-from smckay@internode.on.net)
Received: from dungeon.home (ppp1499.qld.padsl.internode.on.net [150.101.178.218])
	by smtp0.adl1.internode.on.net (8.12.4/8.12.4) with ESMTP id g8ME9Ep5074972;
	Sun, 22 Sep 2002 23:39:14 +0930 (CST)
Received: from dungeon.home (localhost [127.0.0.1])
	by dungeon.home (8.11.6/8.11.6) with ESMTP id g8ME9DB16763;
	Mon, 23 Sep 2002 00:09:13 +1000 (EST)
	(envelope-from mckay)
Message-Id: <200209221409.g8ME9DB16763@dungeon.home>
To: Martin Blapp <mbr@FreeBSD.org>
Cc: current@FreeBSD.org, Stephen McKay <smckay@internode.on.net>
Subject: Re: cvs commit: src/sys/pci if_dc.c 
References: <200209201518.g8KFIDec033289@freefall.freebsd.org>
In-Reply-To: <200209201518.g8KFIDec033289@freefall.freebsd.org>
    from Martin Blapp at "Fri, 20 Sep 2002 15:18:13 +0000"
Date: Mon, 23 Sep 2002 00:09:13 +1000
From: Stephen McKay <smckay@internode.on.net>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On Friday, 20th September 2002, Martin Blapp wrote:

>mbr         2002/09/20 08:18:13 PDT
>
>  Modified files:
>    sys/pci              if_dc.c 
>  Log:
>  Fix the support for the AN985/983 chips, which do not set the
>  RXSTATE to STOPPED, but to WAIT. This should fix hangs which
>  could only be solved by replugging the cable.

John's already mentioned we are still thinking about the right way to
handle this but...

>  MFC after:      2 weeks

... I thought I should explicitly mention that merging this particular
change as it stands is a bad idea because PNIC and Davicom cards (at least)
are not yet correctly handled.  The code in -stable is the old broken but
apparently harmless code.  This new code is attempting to be more correct
but breaks support for some cards.  Odd situation, no?

Stephen.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message