From owner-freebsd-current@freebsd.org Tue Jun 2 00:10:31 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B04B92F76FB for ; Tue, 2 Jun 2020 00:10:31 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660056.outbound.protection.outlook.com [40.107.66.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49bXVt3yB0z4BTJ for ; Tue, 2 Jun 2020 00:10:30 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g/kF7Ts/UPeSPfO0rCKuth4/NjvR+iFYr99W/GwzdJ/Ln2eNutZVNGQHTnzuq7R1pZeIyPfaR1OnYb07iv4q0lDE+OC1xB6uBoHgNFvJRA8U/cqczr3aNxhrlCWCXdn1bsIozyqC3t0uuaYsqcR6cxCcQTs4ps5DxQKq4x/MlrOyTwk9xUw/yDyFeYw1Gulx/FodkZhQ8UuZLCQ7B9ekIwMs1aghOonplfbeQqgsxdsJqlKg1/VqApNdK1ouQe2oYGY7zm0Jy3j2jwroZ+K27BRudZxjq5Zp5jUsz2Ishm/S93SsLj7cZ4G11UYAX9D/xk4XFlMrj4SNOOtcAW/ROw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tQvfHS13u/pP3HDcoVyFQV2aC4BhJywmrdXqJd1Fj2k=; b=HALbaN0zq23UkFEZO1uqSoOqSA9UBTVi9iqwqQg8XuebLVJNO3wVKDLvoKxNKR7yNptkRR/3pxzF8XEm7Akkt9TDzSctOI22sQIJuhOBjTaTkbLcTO2X8PYStOryZ0H80QFdfS67hQTJ9+xldmVMrIAaqgZ4/Dy7710SIH39sjhf64OlVz8sdolLiV2CRh2fG429CS+ado2fl+EqoRRCUd5PVdZjm4CHOeH6ccSR7WQZFTsNsDwA8GwoVAAJAltwo+HIgDfLZW/focjSGtbvdBrarGRH+zkA2nzxX14hIPPGpSxm44eHjDPf9flf937vciNdLkJlmMh7u+14n2UD3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uoguelph.ca; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tQvfHS13u/pP3HDcoVyFQV2aC4BhJywmrdXqJd1Fj2k=; b=atYcSHzs460Cptw092V8/kASeEG+aSltJuM2zPkQ32WREtpVYjKiTmR1smiz9Bzrbws0GxIzjOVR532d8hes5d+VEbQhtOunrb0PaTy0EMlMwcJ9Czt/j0tempbxFjgOmJYTWqpXb6v6n9WbfHUqcQmW5JFFagZhKKVTqlQCbJSfLHoqr78O9PkvzNRMy+Xvt6copIJKH3PMyD1t3evJ3PcfNxWO7+lwKpQMiNZNr7L6i0MJ8XtdiYhx4zOCKKAzsNhIZ1xThx8pphEAhmtRFQqqLsh2Dl3ragO8UpZzkH270V/mdz+nscVm+zwugr3KWcMj7ariCTWyarwNzbgWHQ== Received: from QB1PR01MB3649.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:32::26) by QB1PR01MB2722.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:36::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19; Tue, 2 Jun 2020 00:10:28 +0000 Received: from QB1PR01MB3649.CANPRD01.PROD.OUTLOOK.COM ([fe80::dd96:945c:b6ee:ffa2]) by QB1PR01MB3649.CANPRD01.PROD.OUTLOOK.COM ([fe80::dd96:945c:b6ee:ffa2%6]) with mapi id 15.20.3045.024; Tue, 2 Jun 2020 00:10:28 +0000 From: Rick Macklem To: Pete Wright , FreeBSD Current Subject: Re: vfs_mouse.c breakage? Thread-Topic: vfs_mouse.c breakage? Thread-Index: AQHWOG44NjrGJUkRU0qthR/BlLnNp6jEbMZMgAAFdwCAAAC1cg== Date: Tue, 2 Jun 2020 00:10:28 +0000 Message-ID: References: <557e316f-bd4b-8070-38a6-ed8ad63aed39@nomadlogic.org> , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 737df127-0abb-435c-78d3-08d806895b89 x-ms-traffictypediagnostic: QB1PR01MB2722: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0422860ED4 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iFNyNbTbrjbj7YeOd4++x4nMtXa6an4rnuZdHO9JiklZcKywI6fZRFiNxIMkeFZE4zbxlucL91D6ieH3LEIhoee2+uybFXBY57S1pCk8ESxLRsh4Q3t3ztfvz2HK7v9St3ydg7YJhwMnMf6C1j32AX/lnLSUExyG31w97ePSs1JjjPN6FeCC547XKLklJAGZeLKSUKIa1XumDvvO/cVTCcxk0mkVxF5TRkZnseAdL/EygO83lbmWMbtq0fGG4zM45ekfz2ED5zCZOVU9HhvT62f/f5g4btYhKD7Kf+qnXMI27PbTOQ6vmAxJC12GGt+x x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:QB1PR01MB3649.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFTY:; SFS:(346002)(376002)(39860400002)(136003)(396003)(366004)(66446008)(64756008)(66476007)(66556008)(66946007)(91956017)(76116006)(478600001)(52536014)(110136005)(316002)(2906002)(6506007)(83380400001)(53546011)(5660300002)(186003)(9686003)(8676002)(7696005)(786003)(55016002)(71200400001)(33656002)(8936002)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: RciOGQq3RIGvrL3rw1jlzbKxE4t7kx30OyJQuiZvWMkLe9MgWb95+joMF0O/9xLJHn8fCd5sexTzMoGyNi5LYxKidPwscbYzkxIo2ETQojoqTjepiLGyVyvLrvQIpzr+TSapHKU9YLEF3EcbsHYM6Eb/zdCatm2z9KuFyZ8ZSfWhL/Fg18h2KlmpWA4ZbrGd6Rv8gGlT+dk8Ghb2gsz8WNUPxJIEFfE6tkKLSlRRChPNIgpvVYvstt7HVmcUMeb9xqQPe/Omkvl7QpfPdVrZwzJqVPsBdNEq+iqNhzPUAfO3W2MzcSbwXEj5nTLz8qorKMu/BJVYM5Sthmb+gr7m9N25Jcy6i5tpQSWIFKaEiNLLS4ztiGiwWaz4V3vq9Vfh8FLKzExlIWCG7PaqZrYP1d4CBul+5oCobT2HCJiE+KX+egqec+J1CIXhiUohS6oNUkl1p+bIDVDH2G84EalKE9GPb+nL7nVE22c0bq+0FN3UJIAgie5niF+F8SSL9EXDMaToOfTp8cbriONP/ACBW11MN7odleZtGBOMOIzCPLGQ4VFXO5p7VuEaNevcWG57 x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 737df127-0abb-435c-78d3-08d806895b89 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2020 00:10:28.8187 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: O2tCQVeojhKQueCSmshUgYWbwdCwboQIKf6uoVrrzTAJHbl6sn7vn8457Xd/0tyXAT4eZEGMM2/P/oCoxT2dFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: QB1PR01MB2722 X-Rspamd-Queue-Id: 49bXVt3yB0z4BTJ X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=uoguelph.ca header.s=selector1 header.b=atYcSHzs; dmarc=none; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.66.56 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-4.61 / 15.00]; NEURAL_HAM_MEDIUM(-0.98)[-0.984]; R_DKIM_ALLOW(-0.20)[uoguelph.ca:s=selector1]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; NEURAL_HAM_LONG(-1.05)[-1.051]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[uoguelph.ca]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; DWL_DNSWL_LOW(-1.00)[uoguelph.ca:dkim]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[uoguelph.ca:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[40.107.66.56:from]; NEURAL_HAM_SHORT(-1.07)[-1.071]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; RCVD_TLS_LAST(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[40.107.66.56:from] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jun 2020 00:10:31 -0000 It also needed . It is ancient code (that started out in SunOS. if I recall correctly), wher= e they used things like "bool_t" and set them with TRUE/FALSE (upper case). Unfortunately, those includes love to include other includes... Anyhow, I think it is fixed now, rick ________________________________________ From: Pete Wright Sent: Monday, June 1, 2020 8:05 PM To: Rick Macklem; FreeBSD Current Subject: Re: vfs_mouse.c breakage? CAUTION: This email originated from outside of the University of Guelph. Do= not click links or open attachments unless you recognize the sender and kn= ow the content is safe. If in doubt, forward suspicious emails to IThelp@uo= guelph.ca On 6/1/20 2:50 PM, Rick Macklem wrote: > Pete Wright wrote: >> Subject: vfs_mouse.c breakage? > Not sure if the vfs mouse is broken (sorry, I couldn't resist), but... hah nice - dyslexia + poor eyesight are not good bedfellows :^) > > I think it needs a: > #include > > but it will take a little while for me to test this. > > Thanks for reporting it, rick no prob - adding that include thew some more errors $ git diff diff --git a/sys/kern/vfs_mount.c b/sys/kern/vfs_mount.c index 03f95b2845f9..4282b1938095 100644 --- a/sys/kern/vfs_mount.c +++ b/sys/kern/vfs_mount.c @@ -39,6 +39,7 @@ #include __FBSDID("$FreeBSD$"); +#include #include #include #include here's a snippet of the exception: --- vfs_mount.o --- In file included from /usr/home/pete/git/freebsd/sys/kern/vfs_mount.c:42: In file included from /usr/home/pete/git/freebsd/sys/rpc/auth.h:50: /usr/home/pete/git/freebsd/sys/rpc/xdr.h:105:3: error: type name requires a specifier or qualifier bool_t (*x_getlong)(struct XDR *, long *); I'll sit tight for now - thanks for checking it out! -pete -- Pete Wright pete@nomadlogic.org @nomadlogicLA