From nobody Thu Jun 4 00:36:17 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gW5Gb19ltz6h5yQ for ; Thu, 04 Jun 2026 00:36:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gW5GZ2yfWz3prW for ; Thu, 04 Jun 2026 00:36:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780533382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+WlaP4YzXgUtvyU//C5IvPCgLHpPJGoKc2rq3PLuX0o=; b=tn7zl6Ujh1l2A7TJAo+wgDNAcGfIM1dJmTZLr/IoCraxm2Jcidov3tuZVu7uguUgxetAPN EXcxDAilM9KQb1xYE+YRyAXeYW2tfmyvTaVOExMteHxcnmlGylhTR6GNTGLKsZX8f0eXsU +BxJxmIE2McDJbUqLkRvJgK5lJtKzBRZJVhrdoKkefsiLZtiT0wUrr48FwjNj0TFCuaZBj MqEyh0Hw949Ti2vMyyAGmeE/pRQs0/iTfCNvvbU3IV78PRx4734BBG0LKh6m1rPYrJNjXj JNeIl+Ig+jhumSswSQdHH/4QBz8YORI28ObJRFKy3xRzgLO+CSuKcPAERSuqbw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780533382; a=rsa-sha256; cv=none; b=qJ6HYrIrUxQ5o4l6yMMths1kvcXgyfELJLJrNgUCv9iVflZaO4i7em+6tFvtwmXZu2jHAN +3qf9YuU4ysLkXSloXLKEOc1U62H6xruBtJVsVbKvJxRS6puE6B+ZexhjUc0AcLRyUULdX +DmQ0KBpKacf5vXAlbMWHlJVYAeR3JHcDOJtBmqVd0T+vVWn7HaGZjW/rZLWpoQWeNrJSB DN30CDyR2tfsuszFoEPtcslJsqWF+kEdE8OL/KbsOz6GK+oZsQ6p11k27+XOzbagmzrqJK /Kt2nBBf8Ksj0GYkWUX/IY5NoTvu4QAf9x5yjiPyAzVJx1iF0G+9wXGvhqlUAQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780533382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+WlaP4YzXgUtvyU//C5IvPCgLHpPJGoKc2rq3PLuX0o=; b=MJzwdcKnMXeQPgL8l7GFpVatwULvLQBhz+swcVuhn1D5pb8gwFBNO2Uaw8+CkT2hqpCAZB wmISJE3z9vc4zqDmxrcZmpqPa5sR/x0YAvhKKBwwPGRvMyWnhJ3Bux74WrsPHyPtWxZHVY 9cvVrweW5qraPJuLk1w3jxmNRDaNkXgIlOVlnrn/BAdM9Djz573vSOR4k13vjbQHHOetwU uktojIJoCKKNZ1PQfySHhHIOwi4/nADRVZ3ZlgQnH2AfKX/eaFA7ayZ866ITR3YGH7/Ik1 F5eRnjh8VKsMmUHnW63bK6mRTRGzSuLUxTVx1CIYsSoCxa94JG50OYET09PEfA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gW5GZ2P2bzbQF for ; Thu, 04 Jun 2026 00:36:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 20551 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 04 Jun 2026 00:36:17 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Haoxiang Li From: Konstantin Belousov Subject: git: 21fb5a5e61c3 - stable/15 - smbfs: plug smbfs_node_alloc() leak of name buffers when insmntque() fails List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 21fb5a5e61c333131cfbb4b522db00142a905707 Auto-Submitted: auto-generated Date: Thu, 04 Jun 2026 00:36:17 +0000 Message-Id: <6a20c881.20551.f452cb@gitrepo.freebsd.org> The branch stable/15 has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=21fb5a5e61c333131cfbb4b522db00142a905707 commit 21fb5a5e61c333131cfbb4b522db00142a905707 Author: Haoxiang Li AuthorDate: 2026-05-26 13:21:39 +0000 Commit: Konstantin Belousov CommitDate: 2026-06-04 00:24:13 +0000 smbfs: plug smbfs_node_alloc() leak of name buffers when insmntque() fails PR: 295577 (cherry picked from commit f0e702a7a289f0f350bdaeb943805d6d17f9e403) --- sys/fs/smbfs/smbfs_node.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/fs/smbfs/smbfs_node.c b/sys/fs/smbfs/smbfs_node.c index 9893987f7ccd..b2b5d63e2eaf 100644 --- a/sys/fs/smbfs/smbfs_node.c +++ b/sys/fs/smbfs/smbfs_node.c @@ -212,6 +212,10 @@ smbfs_node_alloc(struct mount *mp, struct vnode *dvp, const char *dirnm, SMBERROR("new vnode '%s' born without parent ?\n", np->n_name); error = insmntque(vp, mp); if (error) { + smbfs_name_free(np->n_name); + free(np->n_rpath, M_SMBNODENAME); + if (np->n_parent != NULL && (np->n_flag & NREFPARENT) != 0) + vrele(np->n_parent); free(np, M_SMBNODE); return (error); }