Date: Wed, 30 Jul 2014 10:42:38 +0200 From: John Marino <freebsd.contact@marino.st> To: Mathieu Arnold <mat@FreeBSD.org>, marino@freebsd.org, Max Brazhnikov <makc@freebsd.org>, Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, William Grzybowski <wg@freebsd.org>, Adam Weinberger <adamw@adamw.org> Subject: Re: svn commit: r363361 - in head/editors/fte: . files Message-ID: <53D8AFFE.3090600@marino.st> In-Reply-To: <79ADB965FF3B933E075F07BD@atuin.in.mat.cc> References: <201407291646.s6TGkjHH090335@svn.freebsd.org> <41D25BC1-AC62-4280-A342-8A2BDD84B1E0@adamw.org> <20140730070412.GA97692@FreeBSD.org> <3898057.T8DsoXnEEp@mercury.ph.man.ac.uk> <53D89EBF.4080805@marino.st> <2D24420529C9ECAEABB9A791@atuin.in.mat.cc> <53D8A2BB.7090704@marino.st> <6270029E710D3C52B60B6224@atuin.in.mat.cc> <53D8A930.3020806@marino.st> <79ADB965FF3B933E075F07BD@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7/30/2014 10:35, Mathieu Arnold wrote: > > > +--On 30 juillet 2014 10:13:36 +0200 John Marino > <freebsd.contact@marino.st> wrote: > | On 7/30/2014 10:08, Mathieu Arnold wrote: > |> > |> > |> +--On 30 juillet 2014 09:46:03 +0200 John Marino > |> <freebsd.contact@marino.st> wrote: > |> | Take a vote. I'd bet the majority of people do not like "__" not just > |> | "someone". > |> > |> But, I think you're missing the point, who cares what the separator is ? > | > | All the people that don't use makepatch because it makes stupid patch > | names care (or any other reason they don't use makepatch). > > You mean there are people that are actually not using make makepatch ? WTF > ? No wonder patch sometime do not apply cleanly... I have my own tool called genpatch that is derived from the pkgsrc took pkgdiff. I suspect pkgdiff is superior in many ways to makepatch, but I haven't verified yet. My patches apply cleanly. And "diff -u <filepath>.orig <filepatch> > patch-<whatwever" works just fine. > > | We obviously care. I care enough that I'm considering going through the > | bureaucratic hassle of getting a patch name convention outlined in > | documentation thus forcing a change to tools like makepatch. Danfe@ > | obviously cares enough about his eyesight to want it changed. > > You're also missing the point where it is already documented. The point is that it is not. If I go up to makepatch author and say, "your tool is making bad patchnames" he'll say, "prove it, what standard is it violating?". And he'll have me because there is no standard. > It is so strange that in open source projects people can argue at no end > about pointless things that do not matter. No, it's strange that some people in open source projects don't think standards matter. You know, as long as we are making barely hidden digs here... John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53D8AFFE.3090600>