From owner-freebsd-fs@FreeBSD.ORG Fri Aug 23 22:35:24 2013 Return-Path: Delivered-To: fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 2416263F for ; Fri, 23 Aug 2013 22:35:24 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 04C232924 for ; Fri, 23 Aug 2013 22:35:24 +0000 (UTC) Received: from zeta.ixsystems.com (unknown [69.198.165.132]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by anubis.delphij.net (Postfix) with ESMTPSA id A479465AD; Fri, 23 Aug 2013 15:35:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=delphij.net; s=anubis; t=1377297323; bh=5d6tsTCq2SwklviaUni8UG/CZXPiauvR22RRmGTfZQ4=; h=Date:From:Reply-To:To:CC:Subject:References:In-Reply-To; b=v43m13J1MCl91kNZm/6/vsDIewaDj++FF2o5L+OZC0+uWBQIvrAPTRbMsmrEq5ZTf KMLC/ZkRR7T3pLlbO+PtSZV6gs8sWssc5cW8Yopus2CFWrnlBOsuyuyTjF1LBr4MgS A9lSbNr4grfOn15ZXooDEwTgX25FwUXj2UwkbMhs= Message-ID: <5217E3AB.8070902@delphij.net> Date: Fri, 23 Aug 2013 15:35:23 -0700 From: Xin Li Organization: The FreeBSD Project MIME-Version: 1.0 To: Alfred Perlstein Subject: Re: expand vfsops for compat References: <5217DF01.4070504@ixsystems.com> In-Reply-To: <5217DF01.4070504@ixsystems.com> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: fs@freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: d@delphij.net List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Aug 2013 22:35:24 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 08/23/13 15:15, Alfred Perlstein wrote: > > Index: sys/mount.h > =================================================================== > > - --- sys/mount.h (revision 254717) > +++ sys/mount.h (working copy) @@ -628,6 +628,12 @@ > vfs_susp_clean_t *vfs_susp_clean; vfs_notify_lowervp_t > *vfs_reclaim_lowervp; vfs_notify_lowervp_t *vfs_unlink_lowervp; + > vfs_mount_t *vfs_spare1; + vfs_mount_t *vfs_spare2; + vfs_mount_t > *vfs_spare3; + vfs_mount_t *vfs_spare4; + vfs_mount_t > *vfs_spare5; + vfs_mount_t *vfs_spare6; }; Can this be just vfs_mount_t *vfs_spare[6]? Also, why 6 slots? (We currently have 17 vfsops, 17+6=23 is a prime number but I don't think we really need a prime number here :). Cheers, - -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (FreeBSD) iQEcBAEBCgAGBQJSF+OrAAoJEG80Jeu8UPuzJ50H/RRKhE87CQIqtagjc9ZtPx0P 20x0gH3Smo3P8iWHr0Z4xGV3Vm+Hz2iua1aJzwQI7WeilHUd+xd7l/nnnLP83Mxh l97mbfmXvBPHeJteuYtN5IbL7Z4qSY1IfJGAsIwUqMfSXk5UnSTK8aAM0vLhNPVb TfEcR+xshqL3NDaqAPDp62I4F9Yma1heAHMlXO+jXm7Hy4VR9qVqGSLojdUUV6SV PEVB0ulm34y0wGs4vRC9X6zQ1ndkKfZhvuJLmBP3U/bHvhE1yhTVNukWCysoOZ6Y /RploLdpiOfKMcCy7vLdfiL1gy6Y7CVbOKpJRYleqrRa2AKBBenEfmmovQXgMrM= =w0Ub -----END PGP SIGNATURE-----