From owner-cvs-all@FreeBSD.ORG Wed Nov 7 02:06:07 2007 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9011416A418 for ; Wed, 7 Nov 2007 02:06:07 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.189]) by mx1.freebsd.org (Postfix) with ESMTP id 2491813C4B2 for ; Wed, 7 Nov 2007 02:06:06 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: by nf-out-0910.google.com with SMTP id b2so1614467nfb for ; Tue, 06 Nov 2007 18:06:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=3ByxpJgDIvvXnCPpTIK5eNl/u9Cjhf6iY7gyB81S0mU=; b=qj46YM8nD2HAq5spNp+LdVlF/wmHe12uTmzxM9YNDIkZEd8jinNwnoQ5HG4ga19YDqXp6cdsuMfBPFLe67nIVtWYL8cUGyImfUS8ZXcoYN62Gm/0cUMLPhJ8jM+H/XUaQSHL+6UbUqmtvOThf63TDfyw0qjC6AHzn/9fBgHlTC8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=qm8zjiWQ+06p4C9EFQzpfG2VVEfbAbLnEKznr7vWuee5eA263M81m3UN/Uyw6qKzuwk6AKbAytJelnfygaVNqOqKZ+hMpyOoG+dDrK+HFJYYBn25c0dmF+/QEWhT+uvGpFqK2/fjtMyN0a40F97Meq4tXjU0dluAjU5rzgxEyug= Received: by 10.86.77.5 with SMTP id z5mr4810334fga.1194399457192; Tue, 06 Nov 2007 17:37:37 -0800 (PST) Received: by 10.86.100.19 with HTTP; Tue, 6 Nov 2007 17:37:37 -0800 (PST) Message-ID: <2a41acea0711061737y188c09a4ob0f6ce8f58ad0ea8@mail.gmail.com> Date: Tue, 6 Nov 2007 17:37:37 -0800 From: "Jack Vogel" To: "Jack F Vogel" In-Reply-To: <200711070133.lA71XTIn068238@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200711070133.lA71XTIn068238@repoman.freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Nov 2007 02:06:07 -0000 On 11/6/07, Jack F Vogel wrote: > jfv 2007-11-07 01:33:29 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sys/dev/em if_em.c if_em.h > Log: > This delta addresses some users experiencing watchdogs under load with > the last driver version. I suspect sheduling to be at the bottom of it, > but this version fixes it by: > - Making FAST interrupt handling off by default, if you want > to use it #define EM_FAST_IRQ in the Makefile. > - Add dual locks, one for the TX subsystem, the other CORE > for things like init and interface managment. > - Add cleaner MSI/X setup code. > - If using FAST interrupts there is now a mechanism in the > watchdog routine to kick off TX cleanups if they have not > been scheduled. > > I think everyone will be happier with this change. > > Revision Changes Path > 1.65.2.28 +327 -144 src/sys/dev/em/if_em.c > 1.32.2.8 +16 -10 src/sys/dev/em/if_em.h > I should add that Mike Silbersack was responsible for the workaround method used in the watchdog. Both Mike and Scott Long were helpful in debugging and discussions solutions. Thanks guys. I made this change now so that it gets some testing and we work out any issues before 6.3. Cheers, Jack