From owner-freebsd-rc@FreeBSD.ORG  Mon Jul 14 22:30:13 2014
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
Delivered-To: freebsd-rc@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 97F10B5D;
 Mon, 14 Jul 2014 22:30:13 +0000 (UTC)
Received: from shxd.cx (unknown [64.201.244.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 818682A7A;
 Mon, 14 Jul 2014 22:30:13 +0000 (UTC)
Received: from 50-196-156-133-static.hfc.comcastbusiness.net
 ([50.196.156.133]:52284 helo=THEMADHATTER)
 by shxd.cx with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.77 (FreeBSD))
 (envelope-from <devin@shxd.cx>)
 id 1X6ccD-000EHR-V0; Mon, 14 Jul 2014 02:32:10 -0700
From: <dteske@FreeBSD.org>
To: <dteske@FreeBSD.org>, "'Allan Jude'" <allanjude@freebsd.org>,
 <freebsd-rc@freebsd.org>
References: <017a01cf9fa4$568196e0$0384c4a0$@FreeBSD.org>
 <53C44272.1070905@freebsd.org> <01ac01cf9fa6$11b84430$3528cc90$@FreeBSD.org>
In-Reply-To: <01ac01cf9fa6$11b84430$3528cc90$@FreeBSD.org>
Subject: RE: Bug 191869 - tmux(1) refuses to start via service(8)
Date: Mon, 14 Jul 2014 15:30:01 -0700
Message-ID: <01e301cf9fb3$276b0080$76410180$@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 15.0
Thread-Index: AQDXdqJNluYbkuaMCPh9UFMAsk9ENwJWW2qzAejHg1adbn728A==
Content-Language: en-us
Sender: devin@shxd.cx
Cc: 'Michael Dexter' <editor@callfortesting.org>
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: "Discussion related to /etc/rc.d design and implementation."
 <freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-rc>,
 <mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc/>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
 <mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Jul 2014 22:30:13 -0000



> -----Original Message-----
> From: devin@shxd.cx [mailto:devin@shxd.cx] On Behalf Of
> dteske@FreeBSD.org
> Sent: Monday, July 14, 2014 1:56 PM
> To: 'Allan Jude'; dteske@FreeBSD.org; freebsd-rc@freebsd.org
> Cc: 'Michael Dexter'
> Subject: RE: Bug 191869 - tmux(1) refuses to start via service(8)
> 
> 
> 
> > -----Original Message-----
> > From: Allan Jude [mailto:allanjude@freebsd.org]
> > Sent: Monday, July 14, 2014 1:50 PM
> > To: dteske@FreeBSD.org; freebsd-rc@freebsd.org
> > Cc: 'Michael Dexter'
> > Subject: Re: Bug 191869 - tmux(1) refuses to start via service(8)
> >
> > On 2014-07-14 16:43, dteske@FreeBSD.org wrote:
> > > Hi -rc,
> > >
> > > I'd like to get a review on a proposed patch to service(8).
> > >
> > > I've filed BUG #191869:
> > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191869
> > >
> > > Proposed commit/message below:
> > >
> > > Fix an issue with service(8) where utilities such as screen(1) and
> > > tmux(1) would behave differently when utilizing rc-script was
> > > invoked
> > manually vs.
> > > service(8). The issue being that these utilities require the TERM
> > > environ variable to be set and service(8) was not passing it down.
> > >
> > > Reported by:	Michael Dexter <editor@callfortesting.org>
> > > Reviewed by:	<your name here>
> > > MFC after:	3 days
> > > X-MFC-to:	stable/10, stable/9
> > > --This line, and those below, will be ignored--
> > >
> > > M    service/service.sh
> > >
> > > <see attached patch.txt>
> > >
> >
> > This fix works for me. Solves the problem with my rc script that
> > starts puppetdb in screen so I can reattach to the console in the
future.
> >
> > I don't think it should cause any problem with the regular scripts as
> > they startup, since TERM will be set to a reasonable default (cons25)
> >
> 
> Thanks Allan,
> 
> If no objections by late tonight, I'll make the commit.

Pinging myself here that I forgot to include in the above
proposed commit message "PR: ####".

New proposed commit message:

Fix an issue with service(8) where utilities such as screen(1) and tmux(1)
would behave differently when utilizing rc-script was invoked manually vs.
service(8). The issue being that these utilities require the TERM environ
variable to be set and service(8) was not passing it down.

Reported by:	Michael Dexter <editor@callfortesting.org>
PR:		bin/191869
Reviewed by:	allanjude
MFC after:	3 days
X-MFC-to:	stable/10, stable/9
--This line, and those below, will be ignored--

M    service/service.sh

-- 
Devin