From owner-cvs-all Wed Aug 11 20:55:46 1999 Delivered-To: cvs-all@freebsd.org Received: from labinfo.iet.unipi.it (labinfo.iet.unipi.it [131.114.9.5]) by hub.freebsd.org (Postfix) with SMTP id 0562114CB6; Wed, 11 Aug 1999 20:55:41 -0700 (PDT) (envelope-from luigi@labinfo.iet.unipi.it) Received: from localhost (luigi@localhost) by labinfo.iet.unipi.it (8.6.5/8.6.5) id DAA03423; Thu, 12 Aug 1999 03:15:32 +0200 From: Luigi Rizzo Message-Id: <199908120115.DAA03423@labinfo.iet.unipi.it> Subject: Re: cvs commit: src/sys/netinet ip_dummynet.c To: green@FreeBSD.org (Brian F. Feldman) Date: Thu, 12 Aug 1999 03:15:31 +0200 (MET DST) Cc: luigi@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org In-Reply-To: from "Brian F. Feldman" at Aug 11, 99 11:44:53 pm X-Mailer: ELM [version 2.4 PL23] Content-Type: text Content-Length: 930 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk > > Add spl() protection to remove that the timer is invoked multiple s/remove/prevent/ ... > I'm pretty sure all this stuff should be in splnet(), not splimp(). it is likely that you are right, but since I used splimp() all over in ip_dummynet, i used the same until i figure out if it is safe to use splnet() instead. The reason i am unsure is that dummynet kind of simulates transmit interrupts, so i am not certain if splimp() is necessary. cheers luigi -----------------------------------+------------------------------------- Luigi RIZZO, luigi@iet.unipi.it . Dip. di Ing. dell'Informazione http://www.iet.unipi.it/~luigi/ . Universita` di Pisa TEL/FAX: +39-050-568.533/522 . via Diotisalvi 2, 56126 PISA (Italy) http://www.iet.unipi.it/~luigi/ngc99/ ==== First International Workshop on Networked Group Communication ==== -----------------------------------+------------------------------------- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message