From owner-cvs-all  Tue Jan 23  3: 5:10 2001
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id AE1D437B699; Tue, 23 Jan 2001 03:04:48 -0800 (PST)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id WAA09426;
	Tue, 23 Jan 2001 22:04:41 +1100
Date: Tue, 23 Jan 2001 22:04:34 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-Sender: bde@besplex.bde.org
To: Matthew Jacob <mjacob@feral.com>
Cc: Matt Jacob <mjacob@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_synch.c
In-Reply-To: <Pine.BSF.4.21.0101230038110.4435-100000@beppo.feral.com>
Message-ID: <Pine.BSF.4.21.0101232158240.36707-100000@besplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Tue, 23 Jan 2001, Matthew Jacob wrote:
> 
> On Tue, 23 Jan 2001, Bruce Evans wrote:
> 
> > On Mon, 22 Jan 2001, Matt Jacob wrote:
> > 
> > > mjacob      2001/01/22 14:22:39 PST
> > > 
> > >   Modified files:
> > >     sys/kern             kern_synch.c 
> > >   Log:
> > >   Move (now) unused variable declaration inside the block (now commented out).
> > 
> > This actually moves the (temporarily) unused declaration to /dev/null.
> > Please ifdef temporary changes.  Don't move them to a wrong place.
> 
> Not sure I follow. I rather think this was the right place to put it. The
> declaration was for a value only used within a (now #if 0'd ) block. I suppose
> I could have nuked the whole block too.

Principle of minimal messes.  The code is correctly placed where it was
since it is not going away.

Bruce



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message