From owner-freebsd-fs@FreeBSD.ORG  Thu Jan 28 18:40:11 2010
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 35A7A1065670
	for <freebsd-fs@hub.freebsd.org>; Thu, 28 Jan 2010 18:40:11 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 24CA28FC16
	for <freebsd-fs@hub.freebsd.org>; Thu, 28 Jan 2010 18:40:11 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o0SIeAGA021095
	for <freebsd-fs@freefall.freebsd.org>; Thu, 28 Jan 2010 18:40:10 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o0SIeAQX021094;
	Thu, 28 Jan 2010 18:40:10 GMT (envelope-from gnats)
Date: Thu, 28 Jan 2010 18:40:10 GMT
Message-Id: <201001281840.o0SIeAQX021094@freefall.freebsd.org>
To: freebsd-fs@FreeBSD.org
From: Mark Linimon <linimon@lonesome.com>
Cc: 
Subject: Re: kern/142924: Small cleanup for the inode struct in ext2fs
	(based on UFS)
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Mark Linimon <linimon@lonesome.com>
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Jan 2010 18:40:11 -0000

The following reply was made to PR kern/142924; it has been noted by GNATS.

From: Mark Linimon <linimon@lonesome.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/142924: Small cleanup for the inode struct in ext2fs
	(based on UFS)
Date: Thu, 28 Jan 2010 12:37:32 -0600

 ----- Forwarded message from "Pedro F. Giffuni" <giffunip@tutopia.com> -----
 
 From: "Pedro F. Giffuni" <giffunip@tutopia.com>
 To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-bugs@FreeBSD.org
 Subject: Re: kern/142924: Small cleanup for the inode struct in ext2fs
 	(based on UFS)
 
 Include two more simple patches from ufs_lookup.c:
 
 CVS 1.54:
 When compacting directories, ufs_direnter() always trusted DIRSIZ()
 to supply the number of bytes to be bcopy()'d to move an entry. If
 d_ino == 0 however, DIRSIZ() is not guaranteed to return a sensible
 length, so ufs_direnter could end up corrupting a directory during
 compaction.
 
 CVS 1.45:
 Extend the sanity checks in ufs_lookup to ensure that each directory
 entry fits within its DIRBLKSIZ block.
 _______
 
 These were meant to fix issues found with dirhash on UFS but ext2fs
 still works here with those changes so I think it's good to have
 them, JIC we end up bringing over dirhash to ext2fs.
 
 ----- End forwarded message -----