From owner-cvs-src-old@FreeBSD.ORG Thu Feb 26 15:52:07 2009 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DCF8A10657A9 for ; Thu, 26 Feb 2009 15:52:07 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id BE2F58FC0C for ; Thu, 26 Feb 2009 15:52:06 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n1QFq6CF089251 for ; Thu, 26 Feb 2009 15:52:06 GMT (envelope-from ed@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n1QFq6PF089250 for cvs-src-old@freebsd.org; Thu, 26 Feb 2009 15:52:06 GMT (envelope-from ed@repoman.freebsd.org) Message-Id: <200902261552.n1QFq6PF089250@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to ed@repoman.freebsd.org using -f From: Ed Schouten Date: Thu, 26 Feb 2009 15:51:54 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_exec.c kern_exit.c kern_malloc.c kern_rwlock.c kern_sig.c kern_synch.c kern_thr.c kern_time.c tty_info.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Feb 2009 15:52:24 -0000 ed 2009-02-26 15:51:54 UTC FreeBSD src repository Modified files: sys/kern kern_exec.c kern_exit.c kern_malloc.c kern_rwlock.c kern_sig.c kern_synch.c kern_thr.c kern_time.c tty_info.c Log: SVN rev 189074 on 2009-02-26 15:51:54Z by ed Remove even more unneeded variable assignments. kern_time.c: - Unused variable `p'. kern_thr.c: - Variable `error' is always caught immediately, so no reason to initialize it. There is no way that error != 0 at the end of create_thread(). kern_sig.c: - Unused variable `code'. kern_synch.c: - `rval' is always assigned in all different cases. kern_rwlock.c: - `v' is always overwritten with RW_UNLOCKED further on. kern_malloc.c: - `size' is always initialized with the proper value before being used. kern_exit.c: - `error' is always caught and returned immediately. abort2() never returns a non-zero value. kern_exec.c: - `len' is always assigned inside the if-statement right below it. tty_info.c: - `td' is always overwritten by FOREACH_THREAD_IN_PROC(). Found by: LLVM's scan-build Revision Changes Path 1.328 +0 -3 src/sys/kern/kern_exec.c 1.318 +0 -2 src/sys/kern/kern_exit.c 1.169 +0 -2 src/sys/kern/kern_malloc.c 1.43 +0 -1 src/sys/kern/kern_rwlock.c 1.367 +1 -5 src/sys/kern/kern_sig.c 1.318 +0 -1 src/sys/kern/kern_synch.c 1.74 +1 -3 src/sys/kern/kern_thr.c 1.146 +0 -2 src/sys/kern/kern_time.c 1.5 +0 -1 src/sys/kern/tty_info.c