From owner-freebsd-current@FreeBSD.ORG Fri May 28 01:31:32 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DA3FD1065745; Fri, 28 May 2010 01:31:32 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from mail-qy0-f181.google.com (mail-qy0-f181.google.com [209.85.221.181]) by mx1.freebsd.org (Postfix) with ESMTP id 7E69E8FC21; Fri, 28 May 2010 01:31:32 +0000 (UTC) Received: by mail-qy0-f181.google.com with SMTP id 11so999447qyk.13 for ; Thu, 27 May 2010 18:31:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=Mr6sE69zWHRnMN9cln/Z3gCtuHbY57k/a27uDioRpsc=; b=KTpYgnLoeqczzX/Fhb77NNfUsduigMKaJRN9U6iiTxKQxtr9//3GDi9ikF2xvH19N7 rLUTNWIP0xG82IVDo3sK01KasRO5879YRzQwV8d5SZCrLYmZGyavJg9MoOVuQZCo+N2j 2/RkWCNCpIPPevVXlth5YAozFjJ3zUvjaPVG8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=eDPxq4I5d/4w9jfEugj1j1gkRUG/sVABRnKpFiKItPwYLEKuK2XGMWRwkxf1buqygM GKc6HS7rWoV08pp0l6CZtTowNjkrBIyyAIpVLSwbUQUoTm4b9ALI/w3Vu+ewL0DMctUy HSEfA0lXfJFdRJUlDNGzWkfus3UlGhnX9TVKs= MIME-Version: 1.0 Received: by 10.229.38.148 with SMTP id b20mr2509781qce.139.1275010292268; Thu, 27 May 2010 18:31:32 -0700 (PDT) Received: by 10.229.190.83 with HTTP; Thu, 27 May 2010 18:31:32 -0700 (PDT) In-Reply-To: <201005271147.20155.jhb@freebsd.org> References: <201005270933.42760.jhb@freebsd.org> <201005271147.20155.jhb@freebsd.org> Date: Thu, 27 May 2010 18:31:32 -0700 Message-ID: From: Garrett Cooper To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Marcelo/Porks , freebsd-current@freebsd.org, Jeff Roberson Subject: Re: SUJ Changes X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 May 2010 01:31:32 -0000 On Thu, May 27, 2010 at 8:47 AM, John Baldwin wrote: > On Thursday 27 May 2010 10:13:38 am Marcelo/Porks wrote: >> On Thu, May 27, 2010 at 10:33 AM, John Baldwin wrote: >> > On Wednesday 26 May 2010 7:56:24 pm Garrett Cooper wrote: >> >> On Wed, May 26, 2010 at 3:52 PM, Marcelo/Porks > wrote: >> >> > >> >> > Hi guys. I'm not sure if I could call this a problem but I can disa= ble >> >> > SU when SUJ is enabled, so SUJ will remain enabled and SU will be >> >> > disabled. >> >> > >> >> > #tunefs -j enable /dev/device >> >> > #tunefs -n disable /dev/device >> >> > >> >> > I did a patch for sbin/tunefs/tunefs.c that disable SUJ when the us= er >> >> > disable SU. Maybe this will be useful for some of you. >> >> > >> >> > Thanks. >> >> > >> >> > >> >> > Index: sbin/tunefs/tunefs.c >> >> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> >> > --- sbin/tunefs/tunefs.c =A0 =A0 =A0 =A0(revision 208580) >> >> > +++ sbin/tunefs/tunefs.c =A0 =A0 =A0 =A0(working copy) >> >> > @@ -460,6 +460,14 @@ >> >> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if ((~sblock.fs_flag= s & FS_DOSOFTDEP) =3D=3D >> > FS_DOSOFTDEP) >> >> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0warn= x("%s remains unchanged as > disabled", >> > name); >> >> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0else { >> >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* al= so disable SUJ */ >> >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if ((= sblock.fs_flags & FS_SUJ) =3D=3D > FS_SUJ) >> > { >> >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 warnx("soft updates journaling >> >> > will be disabled too"); >> >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 journal_clear(); >> >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 sblock.fs_flags &=3D ~FS_SUJ; >> >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 sblock.fs_sujfree =3D 0; >> >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 warnx("remove .sujournal to >> >> > reclaim space"); >> >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 } >> >> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0sblo= ck.fs_flags &=3D ~FS_DOSOFTDEP; >> >> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0warn= x("%s cleared", name); >> >> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0} >> >> >> > I think that attempting to disable SU if SUJ >> > is enabled should just fail with an error message. =A0The sysadmin can= then >> > choose to disable both SUJ and SU if desired. >> >> If SU is disabled and One tries to enable SUJ then SU will be >> automatically enabled. >> So Why not automatically disable SUJ when One tries to disable SU? > > I'm probably not a big fan of either really. :) =A0For something as rarel= y done > as tunefs I would prefer to err on the side of caution and require the ad= min > to explicitly specify everything. Yeah... I suppose that makes more functional sense. -Garrett