From owner-freebsd-threads@FreeBSD.ORG  Fri Jun 11 22:35:22 2004
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
Delivered-To: freebsd-threads@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 678C716A4CE; Fri, 11 Jun 2004 22:35:22 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 5D3AA43D31; Fri, 11 Jun 2004 22:35:22 +0000 (GMT)
	(envelope-from davidxu@freebsd.org)
Received: from freebsd.org (davidxu@localhost [127.0.0.1])
	i5BMYUMu066113;	Fri, 11 Jun 2004 22:34:31 GMT
	(envelope-from davidxu@freebsd.org)
Message-ID: <40CA330F.5090103@freebsd.org>
Date: Sat, 12 Jun 2004 06:32:47 +0800
From: David Xu <davidxu@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.6) Gecko/20040522
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Sean McNeil <sean@mcneil.com>
References: <Pine.GSO.4.10.10406110432370.12394-100000@pcnet5.pcnet.com>
	<1086944114.76446.5.camel@server.mcneil.com>
	<1086946114.76446.16.camel@server.mcneil.com>	 <40C9C465.5080305@freebsd.org>
	<1086977738.70017.9.camel@server.mcneil.com>
In-Reply-To: <1086977738.70017.9.camel@server.mcneil.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: freebsd-threads@freebsd.org
cc: freebsd-amd64@freebsd.org
Subject: Re: signal handler priority issue
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jun 2004 22:35:22 -0000

Sean McNeil wrote:

>On Fri, 2004-06-11 at 07:40, David Xu wrote:
>  
>
>>Sean McNeil wrote:
>>
>>    
>>
>>>Sorry for top-posting, but it may be easier to read this way....
>>>
>>>The program below has an optimization bug in that done isn't declare
>>>volatile.  With that fixed, it works just fine.  I've been attempting to
>>>get boehm-gc working and it seems OK with libc_r, but fails with
>>>libpthread.  It is essentially doing what the program below does, but
>>>for some reason it gets stuck.  Has anyone else been experimenting with
>>>boehm-gc?
>>>
>>>Also, it would really help if I had a debugger that worked with kse
>>>threads.  How is that going?  Tracking down pthread issues right now has
>>>been difficult with the current debugger.  Can anyone throw some patches
>>>my way that may help?
>>> 
>>>
>>>      
>>>
>>Please try the patch:
>>http://people.freebsd.org/~davidxu/kse/thr_sigsuspend.c.diff
>>
>>the patch is for file /usr/src/lib/libpthread/thread/thr_sigsuspend.c,
>>I believe I caught a bug in the sigsuspend(), thread
>>should scan pending signals first, only when there is
>>no pending signal in wait set,  the thread can sleep.
>>    
>>
>
>Also, the mask provided by the sigsuspend call should govern what
>handlers get called.  So the sigmask should be left in place until after
>the _thr_sig_check_pending(curthread) call.
>
>Thanks for catching this :)
>
>Sean
>
>
>
>
>  
>
No the patch is still not correct, before
_thr_sched_switch_unlocked(curthread) returns, signal will be delivered,
so there needs a flag to tell signal dispatching code to use old signal mask
when delivering signal to signal handler. I am working on it,
thanks for your patch.

David Xu