Date: Wed, 10 Mar 2004 08:15:37 -0800 From: Marcel Moolenaar <marcel@xcllnt.net> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 48556 for review Message-ID: <20040310161537.GA36028@dhcp01.pn.xcllnt.net> In-Reply-To: <39071.1078906642@critter.freebsd.dk> References: <200403100801.i2A810eC071863@repoman.freebsd.org> <39071.1078906642@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 10, 2004 at 09:17:22AM +0100, Poul-Henning Kamp wrote: > In message <200403100801.i2A810eC071863@repoman.freebsd.org>, Marcel Moolenaar > > Note that most #ifdef DDB instances have to be replaced > > with #ifdef DEBUG, because DDB is specific to a single > > back-end, not to having debugging support in general. A > > new option, GDB, has been added to add support for gdb. > > This has to be worked-out still. > > #ifdef DEBUG is a singulary bad choice since much code have private > use of that macro. The point of using a define is to be able to get rid of the debugger calls in production systems. It doesn't matter if DEBUG has private meaning as long as it relates to having debugging code. Other than that, anything else is fine too, as long as it's not DDB. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040310161537.GA36028>