From owner-freebsd-hackers@FreeBSD.ORG Mon May 17 07:42:53 2004 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A7F5E16A4CE; Mon, 17 May 2004 07:42:53 -0700 (PDT) Received: from sev.net.ua (sev.net.ua [212.86.233.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2155443D1F; Mon, 17 May 2004 07:42:52 -0700 (PDT) (envelope-from shadow@psoft.net) Received: from berloga.shadowland ([213.227.237.65]) by sev.net.ua (8.12.10/8.12.9) with ESMTP id i4HEgkPs098250; Mon, 17 May 2004 17:42:47 +0300 (EEST) (envelope-from shadow@psoft.net) Received: from berloga.shadowland (berloga.shadowland [127.0.0.1]) by berloga.shadowland (8.12.10/8.12.10) with ESMTP id i4HEgk89008216; Mon, 17 May 2004 17:42:46 +0300 Received: (from root@localhost) by berloga.shadowland (8.12.10/8.12.10/Submit) id i4HEgjgN008214; Mon, 17 May 2004 17:42:45 +0300 From: Alex Lyashkov To: "Kevin A. Pieckiel" In-Reply-To: <20040517130456.GA21383@SDF.LONESTAR.ORG> References: <20040513171659.GA14716@SDF.LONESTAR.ORG> <200405141133.49502.jhb@FreeBSD.org> <20040517130456.GA21383@SDF.LONESTAR.ORG> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: quoted-printable Organization: PSoft Message-Id: <1084804965.7881.2.camel@berloga.shadowland> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) Date: Mon, 17 May 2004 17:42:45 +0300 cc: freebsd-hackers@FreeBSD.org cc: John Baldwin Subject: Re: 5.2.1 panic X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 May 2004 14:42:53 -0000 =F7 =F0=CE=C4, 17.05.2004, =D7 16:04, Kevin A. Pieckiel =D0=C9=DB=C5=D4: > On Fri, May 14, 2004 at 11:33:49AM -0400, John Baldwin wrote: >=20 > > Do 'l *0xc0519a64' in gdb to get the line that it actually faulted on. = Since=20 > > this is likely a NULL pointer deref that might help you fix the bug or = at=20 > > least find out its cause. >=20 > Wow. That's interesting to me. I didn't expect this: >=20 > (kgdb) l *0xc0519a64 > 0xc0519a64 is in quotactl (/usr/src/sys/kern/vfs_syscalls.c:206). > 201 NDFREE(&nd, NDF_ONLY_PNBUF); > 202 error =3D vn_start_write(nd.ni_vp, &mp, V_WAIT | PCATCH); > 203 vrele(nd.ni_vp); > 204 if (error) > 205 return (error); > 206 error =3D VFS_QUOTACTL(mp, uap->cmd, uap->uid, uap->arg, = td); > 207 vn_finished_write(mp); > 208 return (error); > 209 } > 210 Please update you source. It`s bug already fixed at src/sys/kern/vfs_syscalls.c v. 1.345 =3D=3D=3D=3D=3D Modified files: sys/kern vfs_syscalls.c=20 Log: Always use nd.ni_vp->v_mount as an argument for VFS_QUOTACTL(), just like in RELENG_4. =3D=3D=3D=3D=3D --=20 Alex Lyashkov PSoft