From owner-svn-ports-all@FreeBSD.ORG  Sun Oct 28 10:32:56 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id AD17B99F;
 Sun, 28 Oct 2012 10:32:56 +0000 (UTC)
 (envelope-from utisoft@gmail.com)
Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com
 [209.85.214.54])
 by mx1.freebsd.org (Postfix) with ESMTP id A7B838FC08;
 Sun, 28 Oct 2012 10:32:54 +0000 (UTC)
Received: by mail-bk0-f54.google.com with SMTP id jf20so1708263bkc.13
 for <multiple recipients>; Sun, 28 Oct 2012 03:32:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:from:date
 :x-google-sender-auth:message-id:subject:to:cc:content-type;
 bh=LZ6tafIVE7++rpHgc7uEXmXm7+eYcTahsttcvX6yLm8=;
 b=dDw8w+IiPTNyOJgCqXkXHzkhiGmHrXjW6FuqRodXHGH1vzrtDJ78me6x+hf4f9dO5M
 J5MwEYxL266tQwJWccKcy8gEOgm0JxJKqTLy6R6ZwTrJOlEO8mQ34XF6lddQkkr449ns
 iS+6GJuTTh4/ABDgLAM7GTt715s+/gkdkn17z6JJrVKCPoHB8UZPiDlmZntQMxCJkqSA
 aS1ijqfGy2TrwVCf6Nz4mDQC7D/278rMaSEK5stU4X0wN8TJRhL6AXrriIcFFGuY3cHV
 5U2TAlzLDCH67Ja8ehibYDHeBJaADSanl5rS8TmIOUZxhnPm8vkzCFsVltVRknVQajGP
 lv/w==
Received: by 10.205.137.7 with SMTP id im7mr8244482bkc.25.1351420373290; Sun,
 28 Oct 2012 03:32:53 -0700 (PDT)
MIME-Version: 1.0
Sender: utisoft@gmail.com
Received: by 10.204.50.197 with HTTP; Sun, 28 Oct 2012 03:32:22 -0700 (PDT)
In-Reply-To: <CADLo839HBFwYUzMz+=8HNGbpkZUnUK_uVc1QpRUHiFewFUZ8+g@mail.gmail.com>
References: <201210131835.q9DIZJaQ081278@svn.freebsd.org>
 <CADLo839HBFwYUzMz+=8HNGbpkZUnUK_uVc1QpRUHiFewFUZ8+g@mail.gmail.com>
From: Chris Rees <crees@FreeBSD.org>
Date: Sun, 28 Oct 2012 10:32:22 +0000
X-Google-Sender-Auth: vC5Decc60mI5QCQi18Wwq4RnJ4M
Message-ID: <CADLo83-H_ssJe9Jm-ji_ahKDuzWuaARPdU9-mBfsCr=UB6KVXQ@mail.gmail.com>
Subject: Re: svn commit: r305846 - head/security/amavisd-new/files
To: Gabor Kovesdan <gabor@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Oct 2012 10:32:56 -0000

On 14 October 2012 14:22, Chris Rees <crees@freebsd.org> wrote:
> On 13 October 2012 19:35, Gabor Kovesdan <gabor@freebsd.org> wrote:
>> XXX Ports RC script present
>> Author: gabor
>> Date: Sat Oct 13 18:35:19 2012
>> New Revision: 305846
>> URL: http://svn.freebsd.org/changeset/ports/305846
>>
>> Log:
>>   - Fix mistakenly expanded variable substitution
>>
>>   Noticed by:   zeising
>>   Feature safe: yes
>
> These rc scripts can be simplified a fair amount, though I'm afraid I
> don't think I can test these sufficiently rigoroursly to label it
> "tested".
>
> Please take a look!
>
> Chris
>
> [1] http://www.bayofrum.net/~crees/patches/amavisd-rc-script.diff

I've added an explanation at the top of the script.

Mind if I commit?

Chris