From owner-freebsd-ports@freebsd.org Fri Jul 15 16:10:25 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 478F1B9A689 for ; Fri, 15 Jul 2016 16:10:25 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from gw.catspoiler.org (unknown [IPv6:2602:304:b010:ef20::f2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gw.catspoiler.org", Issuer "gw.catspoiler.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 1C74D136D; Fri, 15 Jul 2016 16:10:25 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.15.2/8.15.2) with ESMTP id u6FGAE5N037400; Fri, 15 Jul 2016 09:10:18 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Message-Id: <201607151610.u6FGAE5N037400@gw.catspoiler.org> Date: Fri, 15 Jul 2016 09:10:14 -0700 (PDT) From: Don Lewis Subject: Re: devel/sope: make (stage-qa) now fails with DEVELOPER=yes complaining about iconv dependency To: euan@potensol.com cc: koobs@FreeBSD.org, freebsd-ports@freebsd.org, martin@waschbuesch.de, w.schwarzenfeld@utanet.at In-Reply-To: <7c8e-5788ff80-3-6b8b4580@96884534> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2016 16:10:25 -0000 On 15 Jul, Euan Thoms wrote: > > On Friday, July 15, 2016 15:26 SGT, Kubilay Kocak > wrote: > >> On 15/07/2016 5:17 PM, Martin Waschbüsch wrote: >> > >> >> Am 14.07.2016 um 23:29 schrieb Euan Thoms : >> >> >> >> >> >> On Friday, July 15, 2016 01:11 SGT, Walter Schwarzenfeld >> >> wrote: >> >> >> >>> I think this statements should be only warnings. Cause not all >> >>> of these statements are right and each maintianer should decide >> >>> which "USES" or "LIB_DEPENDS" are necessairely and which not. >> >> >> >> Well, I don't know enough to comment about whether it should be >> >> classed as a warning or an error. But there's definetely a bug in >> >> the ports Mk system, since adding USES+=iconv does not remove the >> >> error. I don't think I even need iconv as a dependency, it should >> >> be included lower down in the dependency tree. >> > >> > I am not sure about this. At the very least, sope-core does use >> > iconv in its NGExtensions (e.g. NSString+Encoding.m). Can we really >> > assume some lower dependency package already pulls iconv in? >> >> If something in a port links to libiconv (or anything else), then >> the dependency should be registered in that port >> > > OK, thanks guys. I will add libiconv as a LIB_DEPENDS. But I still > think there may be a bug. The make error tells me to use USES+=iconv > and it doesn't work, I still get the same error about libiconv not > being specified as a dependancy. It looks like USES=iconv doesn't add the dependency on newer FreeBSD versions that have basic iconv support in the base system. If you set USES=iconv:wchar_t or USES=iconv:translit, then it will unconditionally add the dependency. If you don't use the WCHAR_T or //TRANSLIT extensions, it may not be necessary to link with -liconv, but it is possible that the port does this automatically if it finds that libiconv is installed by another dependency.