Date: Mon, 7 Oct 2019 14:38:59 -0700 From: John Baldwin <jhb@FreeBSD.org> To: Edward Tomasz Napierala <trasz@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r353283 - in head: lib lib/libstats share/man/man3 share/mk sys/amd64/conf sys/conf sys/kern sys/sys tools/build/options Message-ID: <19168116-73e4-7d98-16d3-2ecd38dabfcd@FreeBSD.org> In-Reply-To: <201910071905.x97J56t0039812@repo.freebsd.org> References: <201910071905.x97J56t0039812@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/7/19 12:05 PM, Edward Tomasz Napierala wrote: > Author: trasz > Date: Mon Oct 7 19:05:05 2019 > New Revision: 353283 > URL: https://svnweb.freebsd.org/changeset/base/353283 > > Log: > Introduce stats(3), a flexible statistics gathering API. > > This provides a framework to define a template describing > a set of "variables of interest" and the intended way for > the framework to maintain them (for example the maximum, sum, > t-digest, or a combination thereof). Afterwards the user > code feeds in the raw data, and the framework maintains > these variables inside a user-provided, opaque stats blobs. > The framework also provides a way to selectively extract the > stats from the blobs. The stats(3) framework can be used in > both userspace and the kernel. > > See the stats(3) manual page for details. > > This will be used by the upcoming TCP statistics gathering code, > https://reviews.freebsd.org/D20655. > > The stats(3) framework is disabled by default for now, except > in the NOTES kernel (for QA); it is expected to be enabled > in amd64 GENERIC after a cool down period. Why sys/amd64/conf/NOTES instead of sys/conf/NOTES? The userland library seems to be enabled for all architectures rather than only amd64? > Modified: head/share/man/man3/arb.3 > ============================================================================== > --- head/share/man/man3/arb.3 Mon Oct 7 18:55:40 2019 (r353282) > +++ head/share/man/man3/arb.3 Mon Oct 7 19:05:05 2019 (r353283) > @@ -30,7 +30,7 @@ > .\" > .\" $FreeBSD$ > .\" > -.Dd September 28, 2019 > +.Dd October 2, 2019 > .Dt ARB 3 > .Os > .Sh NAME > @@ -94,7 +94,8 @@ > .Nm ARB_INIT , > .Nm ARB_INSERT , > .Nm ARB_REMOVE , > -.Nm ARB_REINSERT > +.Nm ARB_REINSERT , > +.Nm ARB_RESET_TREE > .Nd "array-based red-black trees" > .Sh SYNOPSIS > .In sys/arb.h Are these changes related? Perhaps it would have been nice to commit this change separately with its own description before the stats(3) commit if so. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19168116-73e4-7d98-16d3-2ecd38dabfcd>