From owner-svn-src-all@FreeBSD.ORG  Mon Jun  1 10:40:05 2015
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 5FC906D9;
 Mon,  1 Jun 2015 10:40:05 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 3B4DC1A99;
 Mon,  1 Jun 2015 10:40:05 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from ralph.baldwin.cx (pool-173-54-116-245.nwrknj.fios.verizon.net
 [173.54.116.245])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 38182B953;
 Mon,  1 Jun 2015 06:40:03 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Dimitry Andric <dim@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r283870 - head/sys/amd64/amd64
Date: Mon, 01 Jun 2015 06:28:53 -0400
Message-ID: <14276941.3c2kAXm4xn@ralph.baldwin.cx>
User-Agent: KMail/4.14.3 (FreeBSD/10.1-STABLE; KDE/4.14.3; amd64; ; )
In-Reply-To: <201506010650.t516oeNY080402@svn.freebsd.org>
References: <201506010650.t516oeNY080402@svn.freebsd.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Mon, 01 Jun 2015 06:40:03 -0400 (EDT)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Jun 2015 10:40:05 -0000

On Monday, June 01, 2015 06:50:40 AM Dimitry Andric wrote:
> Author: dim
> Date: Mon Jun  1 06:50:39 2015
> New Revision: 283870
> URL: https://svnweb.freebsd.org/changeset/base/283870
> 
> Log:
>   Remove unneeded NULL checks in amd64's trap_fatal().
>   
>   Since td_name is an array member of struct thread, it can never be NULL,
>   so the check can be removed.  In addition, curproc can never be NULL,
>   so remove the if statement, and splice the two printfs() together.
>   
>   While here, remove the u_long cast, and use the correct printf format
>   specifier curproc->p_pid.
>   
>   Reviewed by:	kib
>   MFC after:	1 week
>   Differential Revision: https://reviews.freebsd.org/D2695

i386 has the curproc check and pid cast (it dates from < 5 when curproc was
NULL when a CPU was idle (we didn't have idle threads)).  Can you fix it as
well?

-- 
John Baldwin