From owner-svn-src-head@freebsd.org Sat Oct 6 23:03:37 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C21BC10C9255; Sat, 6 Oct 2018 23:03:37 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it1-f177.google.com (mail-it1-f177.google.com [209.85.166.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 63CBF88531; Sat, 6 Oct 2018 23:03:37 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it1-f177.google.com with SMTP id p64-v6so7476438itp.0; Sat, 06 Oct 2018 16:03:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=nl5oQyih8eeeXm+bDbF+BvJGYdPI0BRWba+ttiE6lo0=; b=cv9HcHIHwel2rOzwfCQ44JlDN34lt2WHf/G9j9rKohMM8NJA7e8EdoB8p30kc7zZHV 92ySI6QV9Vmj2cU6VM6IOjVnPSKBpYULgsvAZGybDrhnG9t358+neHPQ8aZSd6AtE+LP dddVYQUJYtnZlqRqIVBHM3iLZut0ZDV6j31tJBsJdoMDMT+oqUX/ZkSEarJbb3GSW92u o7WEhetIvxg0cPDZa/6/yr76X7DJqseM/i46RZznljeKAFomO9IExm6xJNRSymE6riKU 67375kN4Ov+xTjSe1iBd6Mf6RbfYBi5DQsx18IVLjKLuzRBieyKT0l/sHXXMMbVdtEG1 dZ5g== X-Gm-Message-State: ABuFfojQz08LN+LhaPada5o94vYZRX7caeGATSygwExhx3pqS7RZ5meN D2ZJLbTyGvAKdRojHasZnNp38YuY X-Google-Smtp-Source: ACcGV615Ln5voeo2hQS1XHRUABGFRwSqsPzkDEKY28JctmU5tH4TYS/iY6TH4lRDlY0RGI/B6lqshQ== X-Received: by 2002:a02:2405:: with SMTP id f5-v6mr13501512jaa.113.1538865642224; Sat, 06 Oct 2018 15:40:42 -0700 (PDT) Received: from mail-it1-f177.google.com (mail-it1-f177.google.com. [209.85.166.177]) by smtp.gmail.com with ESMTPSA id 65-v6sm2835065itw.44.2018.10.06.15.40.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 06 Oct 2018 15:40:42 -0700 (PDT) Received: by mail-it1-f177.google.com with SMTP id i76-v6so7430447ita.3; Sat, 06 Oct 2018 15:40:42 -0700 (PDT) X-Received: by 2002:a24:b250:: with SMTP id h16-v6mr12227692iti.6.1538865641471; Sat, 06 Oct 2018 15:40:41 -0700 (PDT) MIME-Version: 1.0 References: <201806231820.w5NIKHaS051052@repo.freebsd.org> In-Reply-To: Reply-To: cem@freebsd.org From: Conrad Meyer Date: Sat, 6 Oct 2018 15:40:30 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r335584 - head/sys/crypto/aesni To: Alan Somers Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2018 23:03:37 -0000 Sure, I don't have any objection. On Mon, Oct 1, 2018 at 8:48 AM Alan Somers wrote: > > On Sat, Jun 23, 2018 at 12:20 PM Conrad Meyer wrote: >> >> Author: cem >> Date: Sat Jun 23 18:20:17 2018 >> New Revision: 335584 >> URL: https://svnweb.freebsd.org/changeset/base/335584 >> >> Log: >> aesni(4): Fix {de,en}crypt operations that allocated a buffer >> >> aesni(4) allocates a contiguous buffer for the data it processes if the >> provided input was not already virtually contiguous, and copies the input >> there. It performs encryption or decryption in-place. >> >> r324037 removed the logic that then copied the processed data back to the >> user-provided input buffer, breaking {de,enc}crypt for mbuf chains or >> iovecs with more than a single descriptor. >> >> PR: 228094 (probably, not confirmed) >> Submitted by: Sean Fagan >> Reported by: Emeric POUPON >> X-MFC-With: 324037 >> Security: could result in plaintext being output by "encrypt" >> operation >> >> Modified: >> head/sys/crypto/aesni/aesni.c > > > Can we MFC this now?