From owner-svn-src-head@freebsd.org Tue Apr 4 13:09:35 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B133AD2DF10; Tue, 4 Apr 2017 13:09:35 +0000 (UTC) (envelope-from kevans91@ksu.edu) Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0075.outbound.protection.outlook.com [104.47.42.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 577F8FED; Tue, 4 Apr 2017 13:09:34 +0000 (UTC) (envelope-from kevans91@ksu.edu) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ksu.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=wIFBPD813775G31hag4/KtLgRM+kQAdeHJAD5KFm/OU=; b=rTJgSVPYa5zvlNfF5ikW6tofhm1yda3DpDAGQPBH1dGRkbhHxcqua7IvoSMa/gW1dwHBCsIUtrohPR354riFVY5yeocjgfi9x+hMdA22PkxPGfWPC3jNI14lWT2Ybl3Q80gSV9Ud5D+yjMu3OafxjEN0gKMIEq6Ia/JP/N6PQcg= Received: from DM5PR05CA0014.namprd05.prod.outlook.com (10.173.226.24) by DM5PR05MB3579.namprd05.prod.outlook.com (10.174.242.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1019.8; Tue, 4 Apr 2017 13:09:33 +0000 Received: from SN1NAM02FT064.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e44::201) by DM5PR05CA0014.outlook.office365.com (2603:10b6:3:d4::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1019.8 via Frontend Transport; Tue, 4 Apr 2017 13:09:33 +0000 Authentication-Results: spf=pass (sender IP is 129.130.18.151) smtp.mailfrom=ksu.edu; freebsd.org; dkim=none (message not signed) header.d=none;freebsd.org; dmarc=bestguesspass action=none header.from=ksu.edu; Received-SPF: Pass (protection.outlook.com: domain of ksu.edu designates 129.130.18.151 as permitted sender) receiver=protection.outlook.com; client-ip=129.130.18.151; helo=ome-vm-smtp2.campus.ksu.edu; Received: from ome-vm-smtp2.campus.ksu.edu (129.130.18.151) by SN1NAM02FT064.mail.protection.outlook.com (10.152.72.143) with Microsoft SMTP Server id 15.1.1005.5 via Frontend Transport; Tue, 4 Apr 2017 13:09:32 +0000 Received: from calypso.engg.ksu.edu (calypso.engg.ksu.edu [129.130.43.181]) by ome-vm-smtp2.campus.ksu.edu (8.14.4/8.14.4/Debian-2ubuntu2.1) with ESMTP id v34D9WWb028076; Tue, 4 Apr 2017 08:09:32 -0500 Received: by calypso.engg.ksu.edu (Postfix, from userid 110) id 6A4CA248307; Tue, 4 Apr 2017 08:09:32 -0500 (CDT) Received: from mail-wr0-f174.google.com (mail-wr0-f174.google.com [209.85.128.174]) by calypso.engg.ksu.edu (Postfix) with ESMTPA id 14759248302; Tue, 4 Apr 2017 08:09:30 -0500 (CDT) Received: by mail-wr0-f174.google.com with SMTP id t20so10023377wra.1; Tue, 04 Apr 2017 06:09:30 -0700 (PDT) X-Gm-Message-State: AFeK/H2SsQfB7FoNBP5P+POwzG+iMYRvdlmvclevaScRRox1m4VA0Jmk/RkaAb1jlh8vdMeT7DiXMaoBVlZ0nw== X-Received: by 10.223.135.196 with SMTP id c4mr223559wrc.109.1491311368980; Tue, 04 Apr 2017 06:09:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.39.134 with HTTP; Tue, 4 Apr 2017 06:09:08 -0700 (PDT) In-Reply-To: <9018c8db-2a89-c8b2-750b-fe11ac08333f@freebsd.org> References: <201704032316.v33NGpbo037305@repo.freebsd.org> <4ceb1a18-3a72-c0e3-b2e2-f71d687cd153@freebsd.org> <9018c8db-2a89-c8b2-750b-fe11ac08333f@freebsd.org> From: Kyle Evans Date: Tue, 4 Apr 2017 08:09:08 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r316477 - head/usr.bin/grep To: Andrey Chernov CC: Ed Maste , , , X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:129.130.18.151; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39450400003)(39860400002)(39840400002)(39410400002)(39850400002)(39400400002)(2980300002)(438002)(189002)(377454003)(24454002)(199003)(86362001)(8576002)(84326002)(42186005)(6916009)(2950100002)(93886004)(90966002)(189998001)(7906003)(236005)(305945005)(8936002)(45336002)(55446002)(356003)(8676002)(93516999)(54356999)(63696999)(53546009)(61726006)(606005)(5660300001)(54906002)(50986999)(498394004)(75432002)(9896002)(6306002)(9686003)(229853002)(6246003)(38730400002)(2906002)(59536001)(106466001)(61266001)(512874002)(98316002)(450100002)(46386002)(88552002)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR05MB3579; H:ome-vm-smtp2.campus.ksu.edu; FPR:; SPF:Pass; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; SN1NAM02FT064; 1:UNeQCFBRWXveYL8PHcTKHZofvTIAErONTSTpJZepJokAjslmHJJzTjkdpZdVRV1uTB5PxslMH9+cHU+ubshSYxTsFc+0P+c3P9xoKw6lVgpeMg3Fbnc90eLcuBqP73Lq0doIdESqfxpCzIl1TfFpQnoSjpdOFHRQ+9TfNMlUSyFwcIVJT4WucSZWx06UyHiulbESvOxOtOKRPTtrnG/I/YxsMcsYl5GO0b1aXvn+uFzSwfpwt2aJqDqd7Seu7HczP2HkL5ABPdTNaCoISVvMG87LeI9LXDC7zQma6KaMDgQHNZ36MKSxtUBQ119KGcrEXxpMSwH+i1MG1quB0PSGS8hRsv59X8oZrChQV0ofz878zp3PZ3h8dVAz4ut0VU4VLJyZXC/L+M6NbIQInTWPijH8jwwTkwvlzL1vcsCbpXI0Gacg9jXfZWS5+x59mdToqBGScL6iPrZIr5IHOBkzS2Y8yAjMHIMw/ZEZR3P81d/G2u9T3U2LGcRHhmp09js2pcDRVv6C+NaGVIU+mBwnwhctwogXGfX55M+SNFSFB5o= X-MS-Office365-Filtering-Correlation-Id: 6eb7080d-a246-4801-5564-08d47b5bd628 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(8251501002)(2017030254075)(201703131423075)(201703031133081)(201702281549075); SRVR:DM5PR05MB3579; X-Microsoft-Exchange-Diagnostics: 1; DM5PR05MB3579; 3:WfdQtKkiFSSfnaF9k0+6zYooL1cbHJGag6Tk6PBcF0kHTlslj8okNZhaxXQd53jSlktJycg14e0Rm1LvtwBLMbOK9cGbc431/PQrUpKGF9oHjbPza1lLQxhSeKjgek9NJMyk0CuoQPje8SHEXl0mCWQHF5O2v1bfqlvEgc17oYXgL4fPc2MdrZm+sNXbYH0/NW1CVyf7ym8ATZpZPa9MpPzWPpNW9q2otpV5psHpZ5nbt0sGzx2MAwaGkuvfqSIrdQnj5cihYAmlJV7jMAGjZ7vsVULCiqYPhSw6C3Bwptu0ZsMTNayQr6DOXJl/j9F7lYUbj5bOgayWK8S/Eto7/TTCf3Lzxmz6LuIBXkv9ytz7NVE9NW0w9nXL59CMn1N7kcnQ81U58sAH4R3B+nTEWIMzpwvMzPTy8YMnKOwxnLmEWCh7BRM+9o7yzDcPiXOJcn8WCrMmcRM6apXqbypChkg+sHAE03kzgIPECJt/i4EfVR0sqXaExAHHgSqrglWVD5osRjzhO0wov25r1C/D8Q== X-Microsoft-Exchange-Diagnostics: 1; DM5PR05MB3579; 25:3TfYC3YFgX2DN8thCccb+Scviy+kcYg3UlxWdRbljipGJsEOpMaf/Vn0EzHE2EJ90uf1oQShVH/IhDZ+aKFEC0dzY+kNz2huyvZ7404q5bbyO/hGFSR0p1hvnHhFFLP1IM7+vtjGXEMrKlloKDIJY1nVCf/upt4ypJ+Vx0Au+dZAjtaO6EyKqP+R5LFDnKa4k5oxUy7O9prsJcKgLjLMbuK5XZks8uVdYHwZnVDz4NXUE7Mam0WC7a3buh1CPketOl2eKDDm0QO6TNAjRXlsoFgbdfRW+D5Q/iR4bx1cY6h/CP50/yvN48tF4ppb+61/kdHNDms2TP+tmQpEEdDYJhLj9c/St06zq7ljCfwB8F53IPB816NQnj7U5l/8bUtPLF6B4Os984ByP/bGsZjIhpZffwQ/85WnuFNn7Ge89OH4/NASl/aDEz5lSQzMbThf; 31:jbUNKJPsZzrcq8UeXESDUlJaVAMNLsIoM5DeFRy3hZrfZ7kd/cyMBHvHjBg3JIrDDbDckqtl4JS1bQsfWGQuiUMWw6L4S+GOEIvketF6j4CIUMJx0c0F2A9ZVOWZ5xkuyD/Z01suYNGKPy40iAkh2D3p08/akF05jsKS2VRrdYSnzoSMe3p7JFop9kxzKw1/sygtFM88DjTxW75NWRrK+ZGiIEkbF8ZbXPRNZzdbZD0hEjVIdkmlvvh5ZE2T5wOv2Wi0Do+rINenY2/AhImDUw== X-Microsoft-Exchange-Diagnostics: 1; DM5PR05MB3579; 20:XBE7R0hIBQxDF2G5tevVs2rVRvpwdFen4+OaXbAUBJuEZOW+f932Y3HW7kI20yFDOemMWOnTX3Jmc5St2W1OV5exbulpcjTdLncL+EO34ZZzrCFMnsnCIEinU/qFa9PJoTCduM/Pt3xcKdBNYjc+GwxvnFJbYOQSbYPReEpn9PxCJz0Ey8YgBx62/6KubB1yO6r1VmzzeHG4IvfP/Od1kqTR847qDRyXoWIoOm8OK2bpcwFHVY+sBp2dkOUEF3evldlme5w0e9sZL1ax7pb9P4oSGIA45nEzwI8Kq4tTZKLlqR4KoTmEny+gB25h0Mbmyd/BRn2tl9fWq3n3c86ZsFcm9eVDRPFFWBGaRU+ahg4p4FlvS8M70z9Al/0suHPNDupeVgG8UsjKijEDy/vqI6lXg0KfQv5bSUdi1lTg8Lfg5tAcOSk87mtp7m1VR4m7Wi2+vXtyR830ut1XvIl0H6ywL/DpLDlPRj0ZXwuNEpgOyPOAX7FVkR+D+1fQ40Mb X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(13017025)(13015025)(13024025)(13023025)(13018025)(93006095)(93004095)(10201501046)(3002001)(6041248)(20161123562025)(20161123555025)(20161123564025)(201703131423075)(201702281529075)(201702281528075)(201703061421075)(20161123560025)(6072148); SRVR:DM5PR05MB3579; BCL:0; PCL:0; RULEID:; SRVR:DM5PR05MB3579; X-Microsoft-Exchange-Diagnostics: 1; DM5PR05MB3579; 4:gSfaUs9Yd8ck5NbYg84c29i5Q1YWZpMJ6JmldY2Te564TidDTDsbfWE5V2eMGDVnE2K18xF4fW9KmFyOwFGxH+ngv9h28l8JdCmuOU5xd3xSbUBpBBSoVdFkjQRciFghxUwzrloWz4HEqsqsQXQuV3vjLhyXZ6YqseEFOF3TorKM64myJuRC0LaDJLE8KrZsrMbq2XqRwWX7jbiqLDTG2Il0pvp0W2RE6/jZCx9XGNOLsT4XEiGNrn86xIH8nDiCWY4phV9IQv820UCCTga3kFFrZKna2cptTkelHO845T0QQnblpwc95oEv7w3enjRLi+3cqggs6s31rwQYmOMp1NGqHoz/zdK5Rajz24cJu3lrI54ePgnugLnww2P0wbRPZ4Pp17F+eo9pDyndt/4vM8QIp5zMwJIWUhlm6m+fT8A5VD+oeuX2fMGASWOivuBVQlVashtkEBt2CsaIK9hcg+f4KTLBB6WfZBWwnF6esDXjLveidhSl2qtkAP6cXj0EbNyZe0xWA4lIvmAffKqzIKofu9bncyzrLfaBaL9nzK6f9OCy+F/HTG2GQK5ST26ISn0fzJ462yFnio4cNkHhi5tUrAM0FxRBWjwwmEKAompdYuYj4MpG88ZRGuO4twBWrVQRw/jk0rl/dq296+lOUNOO2jCBuZfUyDrRRGYvf/4qiayuv7AUoSRhevjAI8b49j8aLusEp7XUbrEr+LhgxQn76SiIbJjY6BwG5ZekAz5EqqPpeQOSdHH2279DI+EVYg/SJLSZs08OCGKEb6cHQZQ8YVCRnX+ZV98lQY4vDxliCC2aP140OWy0tgYz0atuq50vu91xDeth/pofbeMwhg== X-Forefront-PRVS: 0267E514F9 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR05MB3579; 23:4VyY3tZEnnUD0N8PnzinUw1Hear+v+rWQjXo2vsdW?= =?us-ascii?Q?0YoSjZoK7xX+h+1zIyDnN2JxvofrpTbghJVHGQHccrbGxU3DQGJVCcmmOQPM?= =?us-ascii?Q?tFryuyjecg+9fc96XUN7SZJZXzMRlBiBRvzp+qGuEPcRxjF0kVNjsN5jzlv4?= =?us-ascii?Q?giTIKfPmwU5Jg2JvB+yWYSkwzySqJQTvQLNBYHCmF50vDDGiwJ/1mknTbE9s?= =?us-ascii?Q?84vovMVBQ9cnebEqx8QbbzMkpLb3D0J7CAPwot2Lua9bBS4kiFXR3M79cxoF?= =?us-ascii?Q?XCZq0uhkTM5JVOXs/CMvlacclB2Tf+I06+Mt4zAgaAj+9+avIDGaknnsHaiM?= =?us-ascii?Q?qj3XprMh2VpgnU5fN2+T0IyT+aCWmozHwMFNXXhsvmaRHgMyy8VUqN6JcUip?= =?us-ascii?Q?vo/cmGA74JFfwRu5FQBh06ELAXE9zLDH6xWEP5Xw/3w1hQXX/+t64yTgj74W?= =?us-ascii?Q?1Ah0uiqNJN5UcyHDk7QimIqARqTSwdpdTgCG4Xhu4dP786FrgxjG4+P30ST8?= =?us-ascii?Q?e4LMhpzTQ3c0d9AsQp0SJL4BwN+imQyoOUhoMX3j2JOVusKw5cenH1b/+L8W?= =?us-ascii?Q?UB2LJ1BFieAaVHBBo9Xz8pfi94wLjSWoW56DIyL7urtDYdU5pU3jDPnwSpo1?= =?us-ascii?Q?r/UgAYvlnvoMjuo3cf29Mu81tAdGkdLSdjsIXoC0elnrsn9lZ/dyi9A06NbU?= =?us-ascii?Q?LsjrsW2D8fDolGf9Z2Mj/v02qo2slrK9A62nUP+u2LZurz+/X2SJSVVCDeFS?= =?us-ascii?Q?wuT/rELJGwakUxsyyGIubX9iVdjZGyw5sS/rtRiLKaqJqXWQKP6PrB5FTJ/o?= =?us-ascii?Q?Gup215qf38HhqOSvRNyb1rNd1AL5K+aCK29KEC62Y1bQJceRN76fj5vhADF8?= =?us-ascii?Q?6SVjtkCqB1S7rkGyiyBKC5JNEEr4u5ITAe4pxrA9GU8YM0PPrHDvojquiZTx?= =?us-ascii?Q?ChaBG6zDbsxpj4Dhc5WczEttjtk4M/NfzHrh3q4Vo2m565i4Ql0jlYuRSWwz?= =?us-ascii?Q?pLmDnyBQsI7sCByCvPxZoxF0cvCA61CwMaGHj0nghN9xcXL2x7ludP/mbLpd?= =?us-ascii?Q?fUYteL2txh3Xi/DzRPEb+WlI7sH7ewIAcHGo/oir18pTaoA+ALy+6TNkxZ5O?= =?us-ascii?Q?gaLWRxb4juQGYDtPhaYqxR4NNUoq+FjqOXGeI0Lp1FOIAtwoqlz02xUlxvil?= =?us-ascii?Q?O973e0KS6HuWeZ1uuS1TSfXsxZ78rKnYK9nLq4AGmsjQHdhdebFVjYhgS4lt?= =?us-ascii?Q?BzbkQD7YNtZ/kSwSTrbMsRTEW8wMlOnlyVWERRcNAjMLOtgQR1j+9Lrg7uF+?= =?us-ascii?Q?XZVxOYRTBlp5vKYJpSH0hAiCoAoOJ9ujJ7gbkFQ/48w?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR05MB3579; 6:eukhSLhelRPmJ1CfnFDa2ZE2ha/gcrC21MEnwfszFy1o1RcP9qMejjbOzbhroYT36OnliQ5mRo1kqaRZf9tBOg4rb5E0XnTWqOFRbPznqfu6XhYKzU/TSTlaUcuA0tbLFYZ5rAcNAJmoljFSskO09LTGST/SE+bf60FwN561I7qbchKI8X/vOvLV7Qe+U6qgbBa0thfxs/HmPC7cm55/UVnxGsG5LyWKP2GvclslszGxn+4GtogGSVA3txjxu6xNPAtbdjvhb+bvbG+BIgC9pn3sPPPhibiBPNeo4AjtXVze5JC368QOf08OY3z4cF4HPsmBPbCuqfo5/WgLh+xEEjdu+zYl7Ikr+3anxrJs9XrWUY7LdvZZSPE3ifdmADsII+vZbp4e3UVb3v8YU73Xfw==; 5:6yTZSxjl0s5KUPjD8q6Wgfko7x6KOY9y4PEa8NrMNf6fRYITjYTv9olc6ZH5wA2LbWGHJhEWA9E46NrQWemr56CmqI4s16k1mk/fDYIZqF7HQTyhoQNw+Go70sWYmzyvmvwnut2yjTocK7kCOtXszQ==; 24:8EiatpVkBBLMkBEWpkgwmkHq9vfs+TxmKxCyl+XmhMafK9S5XzVVA81WI7OumyxYIy76qqLGaws97opbPjTk4GY65Siz/g8FzZFFEJm8N4o= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR05MB3579; 7:bg+ck3rEKUbRTd/XiEGfACHJB9s8YBjvQuH/DaqIgy9DOZlO8w/i5hTqIY7g8y2OhEDYpBYzHdMAqwulYvFilZc24ieP9eHXfORcg+uckjyzY5TNxWwE3iFNuBg7YzihfgC8ADhbi2fGZMwTw8q3FYCVOiyea7oiLX7o+ifTeYzRNi5eK0GNhZNJPLKArMQXR+A3xPLtqXmwy9HUz5kSE95o+lccnv1iSlXMlX2EKsPrOBLy6N7iTpigCsN3gP9fctpLPoYMEB2japBab4HAvfatloCcvIOma3sX/0V9tWbVWCgfJTj+OtBm6OcKFptmT/LaF89jv2OXtoKduWNqlw==; 20:EVFSC/uqzDdAAGeW2U2SAHfhB9yO360Dh4mJxTntQKbAYpe94WiA9FIxorWLG1yIPL93f8EM5ncujp/aQkb89U/Mjbc64aL8IllxFqOxlUVY+T/gyNofkCbTLDRVM0u3nQL+xvUzPw6tMDTQctXtHwac4aw1Fh4xy9/EFedAMBY= X-OriginatorOrg: ksu.edu X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2017 13:09:32.8634 (UTC) X-MS-Exchange-CrossTenant-Id: d9a2fa71-d67d-4cb6-b541-06ccaa8013fb X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=d9a2fa71-d67d-4cb6-b541-06ccaa8013fb; Ip=[129.130.18.151]; Helo=[ome-vm-smtp2.campus.ksu.edu] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR05MB3579 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 13:09:35 -0000 First, apologies, I must rewind: what did you mean initially by "We don't need to handle internally [...]" -- the second half I understand, but it occurs to me that we should already be internally handling \33[m = \33[00m as defined by ANSI. On Tue, Apr 4, 2017 at 7:37 AM, Andrey Chernov wrote: > > IMHO everyday usage by everyone weights much more than occasional > regression tests run which can be fixed instead of this place. F.e. we > already do a lot of local fixes in the NetBSD regression tests instead > of pretending to mimic NetBSD in 100% in the system itself. This is where it gets kind of finnicky, and I'll step out and let others weigh in -- the test I refer to was specifically written by me ( https://reviews.freebsd.org/D10112), and it's entirely to make it easier for me to check and quantify to others where we're actually regressing or improving as I continue fixing things in bsdgrep(1). This is easier to do so when we don't have trivial failures due to minor formatting differences when they should ultimately be interpreted equivalently either way, such as in this case. I expect to be find other quirky bugs in gnugrep(1) while reviewing the remaining PRs in Bugzilla, and thus expect this to be more important in the months to come.