From owner-freebsd-bugs@FreeBSD.ORG Mon Nov 21 12:20:18 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E353D16A41F for ; Mon, 21 Nov 2005 12:20:18 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D320443D4C for ; Mon, 21 Nov 2005 12:20:17 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id jALCKH51006059 for ; Mon, 21 Nov 2005 12:20:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id jALCKHhN006058; Mon, 21 Nov 2005 12:20:17 GMT (envelope-from gnats) Resent-Date: Mon, 21 Nov 2005 12:20:17 GMT Resent-Message-Id: <200511211220.jALCKHhN006058@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, HPS Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F1E6F16A41F for ; Mon, 21 Nov 2005 12:10:23 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id C244443D45 for ; Mon, 21 Nov 2005 12:10:23 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id jALCANR5023609 for ; Mon, 21 Nov 2005 12:10:23 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id jALCANrW023608; Mon, 21 Nov 2005 12:10:23 GMT (envelope-from nobody) Message-Id: <200511211210.jALCANrW023608@www.freebsd.org> Date: Mon, 21 Nov 2005 12:10:23 GMT From: HPS To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Cc: Subject: kern/89362: Stale references to freed memory X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Nov 2005 12:20:19 -0000 >Number: 89362 >Category: kern >Synopsis: Stale references to freed memory >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Nov 21 12:20:17 GMT 2005 >Closed-Date: >Last-Modified: >Originator: HPS >Release: FreeBSD 7-current >Organization: >Environment: FreeBSD 7-current i386 >Description: When one sets up an interrupt handler from the "probe" method of an ISA/PNP/PCI/USB ... device driver, the interrupt name becomes garbled, when using "ps aux |grep irq". This is because the device system frees the pointer returned by "device_get_nameunit(dev)" between probe and attach. I suggest that one extends "device_t" with "char dev_nameunit[16]", and use that, instead of allocating memory. In general, storing any pointers returned by "device_get_nameunit(dev)" in the "device_probe" method, for later use, will cause problems. >How-To-Repeat: Set up an interrupt handler from the "probe" method of a device driver. Store the "device_get_nameunit(dev)" pointer when in the "device_probe" method. Print it out after attach, when the pointer has been freed and allocated again. >Fix: Set up the interrupt handler from the "attach" method of a device driver. Make a copy of "device_get_nameunit(dev)" and not a reference. >Release-Note: >Audit-Trail: >Unformatted: