From owner-freebsd-stable@FreeBSD.ORG  Sun Feb  8 13:45:19 2009
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2F5A9106566C;
	Sun,  8 Feb 2009 13:45:19 +0000 (UTC)
	(envelope-from danny@cs.huji.ac.il)
Received: from kabab.cs.huji.ac.il (kabab.cs.huji.ac.il [132.65.16.84])
	by mx1.freebsd.org (Postfix) with ESMTP id D524E8FC1A;
	Sun,  8 Feb 2009 13:45:18 +0000 (UTC)
	(envelope-from danny@cs.huji.ac.il)
Received: from pampa.cs.huji.ac.il ([132.65.80.32])
	by kabab.cs.huji.ac.il with esmtp
	id 1LW9yH-0003Xm-KS; Sun, 08 Feb 2009 15:45:17 +0200
X-Mailer: exmh version 2.7.2 01/07/2005 with nmh-1.2
To: Robert Watson <rwatson@FreeBSD.org>
In-reply-to: <alpine.BSF.2.00.0902081318000.89719@fledge.watson.org> 
References: <E1LW5Ht-0000VH-D8@kabab.cs.huji.ac.il> 
	<20090208091656.GA31876@test71.vk2pj.dyndns.org>
	<E1LW60v-0000zC-B2@kabab.cs.huji.ac.il>
	<20090208104253.GB31876@test71.vk2pj.dyndns.org>
	<alpine.BSF.2.00.0902081252300.1129@fledge.watson.org>
	<E1LW9WA-0003Fu-O4@kabab.cs.huji.ac.il>
	<alpine.BSF.2.00.0902081318000.89719@fledge.watson.org>
Comments: In-reply-to Robert Watson <rwatson@FreeBSD.org>
	message dated "Sun, 08 Feb 2009 13:18:57 +0000."
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Sun, 08 Feb 2009 15:45:17 +0200
From: Danny Braniss <danny@cs.huji.ac.il>
Message-ID: <E1LW9yH-0003Xm-KS@kabab.cs.huji.ac.il>
Cc: Peter Jeremy <peter@vk2pj.dyndns.org>, freebsd-stable@freebsd.org
Subject: Re: impossible packet length ... 
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 08 Feb 2009 13:45:19 -0000

> 
> On Sun, 8 Feb 2009, Danny Braniss wrote:
> 
> > looking at the bce source, it's not clear (to me :-). If errors are detected 
> > in bce_rx_intr(), the packet gets dropped, which I would expect to be the 
> > treatment of an offloded chekcum error, but it seems that is not the case.
> 
> I think we're thinking of different checksums -- devices/device drivers drop 
> frames with bad ethernet checksums, but not IP and above layer checksums.

I know I'm stepping on thin ice hear - haven't touched Stevens for a while,
(and I doubt it mentions offloading), but if the offload checksum is bad,
why not just drop the packet?

The way I read the driver, if the offload checksum is on, and if no
errors where detected, then it's marked as ok.

danny