From owner-cvs-usrsbin Fri May 9 22:27:50 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id WAA19520 for cvs-usrsbin-outgoing; Fri, 9 May 1997 22:27:50 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id WAA19476; Fri, 9 May 1997 22:27:37 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.5/8.6.9) id PAA06538; Sat, 10 May 1997 15:24:28 +1000 Date: Sat, 10 May 1997 15:24:28 +1000 From: Bruce Evans Message-Id: <199705100524.PAA06538@godzilla.zeta.org.au> To: bde@zeta.org.au, brian@awfulhak.org Subject: Re: cvs commit: src/usr.sbin/ppp timer.c Cc: ache@nagual.pp.ru, brian@FreeBSD.ORG, cvs-all@FreeBSD.ORG, CVS-committers@FreeBSD.ORG, cvs-usrsbin@FreeBSD.ORG Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >> Actually it is, read the kernel source :-). The kernel checks the interval >> even when it doesn't use it and fails without doing anything if the interval >> is garbage (tv_sec < 0 || tv_sec > 10^8 || tv_usec < 0 || tv_usec >= 10^6). > >Should I fix kern/kern_time.c then ? No, it's not incorrect. It does almost exactly what the ERRORS section in the man page says: it returns EINVAL if "_a_ value parameter specified a time that was too large to be handled". The man page is just sloppy in not mentioning that it returns EINVAL if a value parameter was invalid. Bruce