From owner-freebsd-hackers@FreeBSD.ORG Wed Sep 19 10:23:14 2012 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1AD7B106564A for ; Wed, 19 Sep 2012 10:23:14 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id CCA758FC08 for ; Wed, 19 Sep 2012 10:23:13 +0000 (UTC) Received: by obbun3 with SMTP id un3so1117064obb.13 for ; Wed, 19 Sep 2012 03:23:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=eOerRcMNF+TEAKJaWyO0CP8JG9x4jpPlZhttsPfMI8s=; b=BMc/uNVARekCv5BhMGj/I4usbGRpYd1mdGQYVhZrJaIaAWU63ewbgj2V8kKCnkBWMt IhHrvKJ1rvESTzwtJADNuoSq2r+cYdiORgE+U7RaIc3W+Mhu0/g9XUxKHadCn+ZbM21Y a9YfPLgrnfUBWnfxOqgNH7FIlgWvd2iFNnDEgY6x6j0fYROga/XzWB7ZPRFxT42VBhsu xvJH6CEwE9kbs9QXXGLcybJcn/YMigCuhrA1aeEnWuYlZq4T8kKNSfID2Y+2oXhSvlrg qxbLCPPKJMG5j0QOr4ikXLIvKIEK9ysA5OWAQso9oJaWP+XCL7fnXxtQtRproC7vuUUw rvbA== MIME-Version: 1.0 Received: by 10.60.19.195 with SMTP id h3mr2519693oee.102.1348050193096; Wed, 19 Sep 2012 03:23:13 -0700 (PDT) Received: by 10.76.142.201 with HTTP; Wed, 19 Sep 2012 03:23:13 -0700 (PDT) In-Reply-To: References: <63FCC95F-7D73-423D-892D-DB5D75BCEBE7@cederstrand.dk> Date: Wed, 19 Sep 2012 03:23:13 -0700 Message-ID: From: Garrett Cooper To: Erik Cederstrand Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: FreeBSD Hackers Subject: Re: NDEBUG and assert() X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Sep 2012 10:23:14 -0000 On Wed, Sep 19, 2012 at 3:18 AM, Erik Cederstrand wro= te: > Den 19/09/2012 kl. 11.19 skrev Erik Cederstrand : > >> The below below patch will let the analyzer reason correctly about the c= ode, and removes the report mentioned above (and a handful others in ncurse= s). It doesn't touch contrib code, but I'm not happy about changing include= /assert.h since it's used so many other places. Any other ideas for how to = best solve this? > > An alternative that doesn't touch assert.h but contains a patch to /contr= ib: This should be disabled [in part because it can be properly enabled with WITH_ASSERT_DEBUG=3Dyes in /etc/src.conf]. Thanks! -Garrett