From owner-svn-src-head@freebsd.org Tue Jan 7 10:38:56 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7B2751FF52F; Tue, 7 Jan 2020 10:38:56 +0000 (UTC) (envelope-from br@bsdpad.com) Received: from sc1.bsdpad.com (sc1.bsdpad.com [163.172.212.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47sTPr2dHyz3ycX; Tue, 7 Jan 2020 10:38:56 +0000 (UTC) (envelope-from br@bsdpad.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=bsdpad.com; s=20190317; h=Subject:To:From; bh=38bmMhNlFuOOSEhAza/ZHL0ByfbZwziWCJCHArQOf1M=; b=a+xuq/BjHhBC44tXYK3va1tEhs Hzn2Gd8WqdWPiiww5wEW+n2Kiz2pFxh8SoJXY1hNXE5Y1kBKGLQG+GDgwmVK1+xYJ7zAAPKU0aHiO iCsSHy+YozAZBpSUEsYJiAj6xQbQRSvMDpIn6iCJHYaQ7iQgo2gSlPLxCZ9LSGQJPcDt9A36ZCsc6 6KtZsfuShpK2lJ/3BUamKJ2mqaYtlYaQmBsXiP1psn/BqScj/DjQzTEPwymii9LeC0UYcc1z1B9qJ cr0J+PW6a88HmsdlU/B5NfViIG0zj72tKr+rhieeOlJrT0tHI/HmAu5puQm9zk2YXoaBwreNt/DL2 kX2oBVhg==; Received: from localhost ([127.0.0.1] helo=bsdpad.com) by sc1.bsdpad.com with smtp (Exim 4.91 (FreeBSD)) (envelope-from ) id 1iomB4-000AEb-FS; Tue, 07 Jan 2020 10:33:34 +0000 Received: by bsdpad.com (nbSMTP-1.00) for uid 1001 br@bsdpad.com; Tue, 7 Jan 2020 10:33:34 +0000 (GMT) Date: Tue, 7 Jan 2020 10:33:34 +0000 From: Ruslan Bukin To: Kristof Provost Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r356438 - head/sys/riscv/sifive Message-ID: <20200107103334.GA39280@bsdpad.com> References: <202001070902.00792Exb001134@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <202001070902.00792Exb001134@repo.freebsd.org> User-Agent: Mutt/1.11.2 (2019-01-07) X-Rspamd-Queue-Id: 47sTPr2dHyz3ycX X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.99 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.989,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-0.999,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jan 2020 10:38:56 -0000 On Tue, Jan 07, 2020 at 09:02:14AM +0000, Kristof Provost wrote: > Author: kp > Date: Tue Jan 7 09:02:14 2020 > New Revision: 356438 > URL: https://svnweb.freebsd.org/changeset/base/356438 > > Log: > sifive: Fix incorrect tx/rx ctrl defines > > Happily these were never used, but they should be correct anyway. > > Reported by: Nicholas O'Brien > Sponsored by: Axiado > > Modified: > head/sys/riscv/sifive/sifive_uart.c > > Modified: head/sys/riscv/sifive/sifive_uart.c > ============================================================================== > --- head/sys/riscv/sifive/sifive_uart.c Tue Jan 7 05:33:33 2020 (r356437) > +++ head/sys/riscv/sifive/sifive_uart.c Tue Jan 7 09:02:14 2020 (r356438) > @@ -64,11 +64,11 @@ __FBSDID("$FreeBSD$"); > #define SFUART_TXCTRL 0x08 > #define SFUART_TXCTRL_ENABLE 0x01 > #define SFUART_TXCTRL_NSTOP 0x02 > -#define SFUART_TXCTRL_TXCNT 0xb0000 > +#define SFUART_TXCTRL_TXCNT 0x70000 > #define SFUART_TXCTRL_TXCNT_SHIFT 16 > #define SFUART_RXCTRL 0x0c > #define SFUART_RXCTRL_ENABLE 0x01 > -#define SFUART_RXCTRL_RXCNT 0xb0000 > +#define SFUART_RXCTRL_RXCNT 0x70000 > #define SFUART_RXCTRL_RXCNT_SHIFT 16 > #define SFUART_IRQ_ENABLE 0x10 > #define SFUART_IRQ_ENABLE_TXWM 0x01 That could be #define SFUART_RXCTRL_RXCNT_SHIFT 16 #define SFUART_RXCTRL_RXCNT_MASK (0x7 << SFUART_RXCTRL_RXCNT_SHIFT) Ruslan