Date: Sun, 30 Aug 2015 13:53:19 +0200 From: Carlos J Puga Medina <cpm@fbsd.es> To: Shane Ambler <FreeBSD@ShaneWare.Biz>, emorrasg@yahoo.es Cc: freebsd-questions <freebsd-questions@freebsd.org> Subject: Re: fetch a distribution file using the git commit Message-ID: <1440935599.4939.3.camel@fbsd.es> In-Reply-To: <55E2CE39.5010102@ShaneWare.Biz> References: <1440840184.30127.5.camel@fbsd.es> <55E2CE39.5010102@ShaneWare.Biz>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-AwXw6OH/kcdcC3zsGYpM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2015-08-30 at 19:04 +0930, Shane Ambler wrote: > On 29/08/2015 18:53, Carlos J Puga Medina wrote: > > > It works for me as expected, but is this line from the=20 > > > configuration > > > file? if yes, it should have "": > >=20 > > > MASTER_SITES_tl-parser=3D" > > https://codeload.github.com/vysheng/tl-parser/tar.gz/1659d87?dummy=3D > > " > >=20 > > No. The MASTER_SITES is set by GH_* variables. >=20 > That's not from the makefile, it is the output during the fetch=20 > stage. >=20 > > See for details: > > https://www.freebsd.org/doc/en/books/porters-handbook/makefile-dist > > file > > s.html#makefile-master_sites-github > >=20 > > > not found > > > *** Error code 127 > > >=20 > > > Here it is the relevant part in the Makefile > > > USE_GITHUB=3D yes > > > GH_ACCOUNT=3D vysheng > > > GH_PROJECT=3D tgl:tgl tl-parser:tl-parser > > > GH_TAGNAME=3D 2.0.1:tgl 1659d87:tl-parser > > >=20 >=20 > Yes using multiple github groups has been working for a couple of > months now and they had me stumped at first too, you need two small > changes. >=20 > The first is that you must use the default group, this is misleading=20 > as > the example in the porters handbook matches what you have done and=20 > the > non-github use of groups does not enforce a default group. In the > second paragraph to 5.4.3.1 it does say "The main value can either=20 > have > no tag, or the :DEFAULT tag" - so you should remove the usage of :tgl > - not specifying a group name implies :DEFAULT >=20 > The second issue is that the group name does not like the '-' sign in > the name. As detailed under 5.4.8.2 - "Elements can be postfixed with > :n where n is [^:,]+, that is, n could conceptually be any=20 > alphanumeric > string but we will limit it to [a-zA-Z_][0-9a-zA-Z_]+ for now." >=20 > This leads to the following to get it working - >=20 > USE_GITHUB=3D yes > GH_ACCOUNT=3D vysheng > GH_PROJECT=3D tgl tl-parser:tlparser > GH_TAGNAME=3D 2.0.1 1659d87:tlparser >=20 >=20 > While the porters handbook has been updated since I suggested some > changes I think it could still be improved a little. > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D172964 >=20 I didn't have any idea about this change. Now it can fetch properly all distribution files. =20 Thanks, Shane! --=20 Carlos Jacobo Puga Medina <cpm@fbsd.es> PGP fingerprint =3D C60E 9497 5302 793B CC2D BB89 A1F3 5D66 E6D0 5453 --=-AwXw6OH/kcdcC3zsGYpM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAABAgAGBQJV4u6vAAoJEKHzXWbm0FRTKosH/jxa7UIFII77H/7WvYVqM1Pw O6vjej8srcdB02AW1r2Lh860f4Dsw/njV9p2zPBJM0VVjiUJbXSjI3GK+se3R9UT Ek21BkwnZmyXCcqIWd7UsyqofbCjcFHvQB482/R8DjHAe3VqNlmndwAZuCgedwEq IRLlmJPU4fZ2OxtFtit0aL+PuHJc3OONgSr7tjuDjcKSh/u8ZB2AMYofNLaJcy7K BY18LuTc1kfzKonj8puCcZ2U/mP5ddJJUQcUF56Eopvu4KP+cehUpPBw3rn9nHed xfmQ7GPaYKBvRbCAj/OpGmgZ1gXoLWZ7yIH3tJv5MUnuUpWu9YD1fNp5Ezg6DLs= =4POI -----END PGP SIGNATURE----- --=-AwXw6OH/kcdcC3zsGYpM--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1440935599.4939.3.camel>