From owner-svn-src-all@freebsd.org Sun Nov 5 21:59:40 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8FA7FE533E6; Sun, 5 Nov 2017 21:59:40 +0000 (UTC) (envelope-from mjg@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5E2976E0E5; Sun, 5 Nov 2017 21:59:40 +0000 (UTC) (envelope-from mjg@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id vA5Lxdtq094282; Sun, 5 Nov 2017 21:59:39 GMT (envelope-from mjg@FreeBSD.org) Received: (from mjg@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id vA5Lxdr3094281; Sun, 5 Nov 2017 21:59:39 GMT (envelope-from mjg@FreeBSD.org) Message-Id: <201711052159.vA5Lxdr3094281@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: mjg set sender to mjg@FreeBSD.org using -f From: Mateusz Guzik Date: Sun, 5 Nov 2017 21:59:39 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r325451 - head/sys/kern X-SVN-Group: head X-SVN-Commit-Author: mjg X-SVN-Commit-Paths: head/sys/kern X-SVN-Commit-Revision: 325451 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Nov 2017 21:59:40 -0000 Author: mjg Date: Sun Nov 5 21:59:39 2017 New Revision: 325451 URL: https://svnweb.freebsd.org/changeset/base/325451 Log: namecache: skip locking in cache_lookup_nomakeentry if there is no entry Modified: head/sys/kern/vfs_cache.c Modified: head/sys/kern/vfs_cache.c ============================================================================== --- head/sys/kern/vfs_cache.c Sun Nov 5 21:43:26 2017 (r325450) +++ head/sys/kern/vfs_cache.c Sun Nov 5 21:59:39 2017 (r325451) @@ -1163,6 +1163,9 @@ retry_dotdot: hash = cache_get_hash(cnp->cn_nameptr, cnp->cn_namelen, dvp); blp = HASH2BUCKETLOCK(hash); retry: + if (LIST_EMPTY(NCHHASH(hash))) + goto out_no_entry; + rw_rlock(blp); LIST_FOREACH(ncp, (NCHHASH(hash)), nc_hash) { @@ -1175,10 +1178,7 @@ retry: /* We failed to find an entry */ if (ncp == NULL) { rw_runlock(blp); - SDT_PROBE3(vfs, namecache, lookup, miss, dvp, cnp->cn_nameptr, - NULL); - counter_u64_add(nummisszap, 1); - return (0); + goto out_no_entry; } counter_u64_add(numposzaps, 1); @@ -1190,6 +1190,10 @@ retry: goto retry; } cache_free(ncp); + return (0); +out_no_entry: + SDT_PROBE3(vfs, namecache, lookup, miss, dvp, cnp->cn_nameptr, NULL); + counter_u64_add(nummisszap, 1); return (0); }