From owner-cvs-src@FreeBSD.ORG Wed Jun 2 09:55:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E20B616A4D0 for ; Wed, 2 Jun 2004 09:55:13 -0700 (PDT) Received: from mail5.speakeasy.net (mail5.speakeasy.net [216.254.0.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id BEC8243D3F for ; Wed, 2 Jun 2004 09:55:13 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 7512 invoked from network); 2 Jun 2004 16:55:03 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 2 Jun 2004 16:55:02 -0000 Received: from 10.50.41.233 (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i52GsuZp065725; Wed, 2 Jun 2004 12:54:57 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Nate Lawson Date: Wed, 2 Jun 2004 12:55:41 -0400 User-Agent: KMail/1.6 References: <20040602093847.D53A516A520@hub.freebsd.org> <20040602093149.D35427@root.org> In-Reply-To: <20040602093149.D35427@root.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200406021255.41118.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Poul-Henning Kamp cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/boot/i386/boot2 boot1.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2004 16:55:14 -0000 On Wednesday 02 June 2004 12:36 pm, Nate Lawson wrote: > On Wed, 2 Jun 2004, Poul-Henning Kamp wrote: > > phk 2004/06/02 02:38:33 PDT > > > > FreeBSD src repository > > > > Modified files: > > sys/boot/i386/boot2 boot1.S > > Log: > > Some embedded platforms have no keyboard controller. Give up waiting > > for it to react after a timeout. > > > > Revision Changes Path > > 1.28 +11 -4 src/sys/boot/i386/boot2/boot1.S > > > > --- src/sys/boot/i386/boot2/boot1.S:1.27 Fri May 14 13:29:29 2004 > > +++ src/sys/boot/i386/boot2/boot1.S Wed Jun 2 02:38:32 2004 > > @@ -197,13 +197,16 @@ > > xorb %al,%al # Zero assumed bss from > > rep # the end of boot2.bin > > stosb # up to 0x10000 > > - callw seta20 # Enable A20 > > - jmp start+MEM_JMP-MEM_ORG # Start BTX > > + > > By removing the callw/retw and moving the jmp to the end, A20 enable can't > be called as a subroutine from elsewhere. Will it be needed elsewhere? No. > > /* > > * Enable A20 so we can access memory above 1 meg. > > + * Use the zero-valued %cx as a timeout for embedded hardware which do > > not + * have a keyboard controller. > > */ > > seta20: cli # Disable interrupts > > -seta20.1: inb $0x64,%al # Get status > > Should be a "movw TIMEOUT, %cx" here. (Or whatever the timeout constant > is.) xor %cx,%cx is smaller > > +seta20.1: dec %cx # Timeout? > > + jz seta20.3 # Yes > > + inb $0x64,%al # Get status > > testb $0x2,%al # Busy? > > jnz seta20.1 # Yes > > movb $0xd1,%al # Command: Write > > -Nate -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org