From owner-cvs-all@FreeBSD.ORG  Mon Jun 28 06:04:24 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D33F116A4CE; Mon, 28 Jun 2004 06:04:24 +0000 (GMT)
Received: from voodoo.oberon.net (voodoo.oberon.net [212.118.165.100])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 83FBE43D41; Mon, 28 Jun 2004 06:04:20 +0000 (GMT)
	(envelope-from krion@voodoo.oberon.net)
Received: from krion by voodoo.oberon.net with local (Exim 4.34 (FreeBSD))
	id 1BepFZ-0004L5-Ug; Mon, 28 Jun 2004 08:04:17 +0200
Date: Mon, 28 Jun 2004 08:04:17 +0200
From: Kirill Ponomarew <krion@voodoo.oberon.net>
To: Pav Lucistnik <pav@FreeBSD.org>
Message-ID: <20040628060417.GM71637@voodoo.oberon.net>
References: <200406271812.i5RICLjj014328@repoman.freebsd.org>
	<20040627235229.GA36136@misty.eyesbeyond.com>
	<1088380914.969.10.camel@hood.oook.cz>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="w2xx78T4DcG3O+DJ"
Content-Disposition: inline
In-Reply-To: <1088380914.969.10.camel@hood.oook.cz>
X-NCC-Regid: de.oberon
X-NIC-HDL: KP869-RIPE
cc: Greg Lewis <glewis@eyesbeyond.com>
cc: cvs-ports@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/math/gnuplot Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Jun 2004 06:04:25 -0000


--w2xx78T4DcG3O+DJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Jun 28, 2004 at 02:01:54AM +0200, Pav Lucistnik wrote:
=20
> In the unattended build, when no OPTIONS dialog is displayed, you don't
> have any WITH* and WITHOUT* variables set. Your port should behave as if
> default values were selected.
>=20
> OPTIONS=3D	OPTION "foo" on
>=20
> Default is to have OPTION on. When no WITH/WITHOUT* variables are
> generated, your test
>=20
> .if defined(WITH_OPTION)
>=20
> will fail. That's now the default you wanted. If you check instead
>=20
> .if !defined(WITHOUT_OPTION)
>=20
> it will work correctly in case OPTIONS were not processed. This nicely
> demonstrates in unattended build on packages on Bento, for example.
>=20
> > Also, why wasn't the PR assigned to the maintainer (me :)?
>=20
> Ask krion :)

Yeah, I should dress up my pointyhat for that ;)

-Kirill

--w2xx78T4DcG3O+DJ
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFA37ThQC1G6a60JuURAt4qAKCAkOJY9+hfMFnDecu3azIo9llztwCgm9fh
dyF+0SjN9iEbthnrOxamkJU=
=5diq
-----END PGP SIGNATURE-----

--w2xx78T4DcG3O+DJ--