From owner-cvs-ports@FreeBSD.ORG  Wed Oct 14 09:09:23 2009
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 47DAD106568B;
	Wed, 14 Oct 2009 09:09:23 +0000 (UTC) (envelope-from des@des.no)
Received: from tim.des.no (tim.des.no [194.63.250.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 04BAD8FC12;
	Wed, 14 Oct 2009 09:09:22 +0000 (UTC)
Received: from ds4.des.no (des.no [84.49.246.2])
	by smtp.des.no (Postfix) with ESMTP id DB5A96D41B;
	Wed, 14 Oct 2009 09:09:21 +0000 (UTC)
Received: by ds4.des.no (Postfix, from userid 1001)
	id 5E57A84513; Wed, 14 Oct 2009 11:09:21 +0200 (CEST)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Doug Barton <dougb@FreeBSD.org>
References: <200910131851.n9DIpB7P057665@repoman.freebsd.org>
	<4AD4DE92.3090808@FreeBSD.org> <86iqeietvu.fsf@ds4.des.no>
	<4AD551E2.3010407@FreeBSD.org> <86tyy2d1si.fsf@ds4.des.no>
	<4AD55971.3080506@FreeBSD.org>
Date: Wed, 14 Oct 2009 11:09:20 +0200
In-Reply-To: <4AD55971.3080506@FreeBSD.org> (Doug Barton's message of "Tue, 13
	Oct 2009 21:54:09 -0700")
Message-ID: <86tyy2cpfj.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.95 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/www/varnish Makefile ports/www/varnish/files
	pkg-message.in varnishd.in varnishlog.in varnishncsa.in
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Oct 2009 09:09:23 -0000

Doug Barton <dougb@FreeBSD.org> writes:
> Dag-Erling Sm=C3=B8rgrav <des@des.no> writes:
> > That's a lot of extra code for no perceivable benefit...
> The if/else code is essentially the same as yours. Splitting out the
> flags that are common between your two options makes the code more
> readable. There is also the issue that code in rc.d scripts shouldn't
> run unconditionally, but I don't regard that as critical in this case
> since you're just setting variables.
>
> Ultimately it's up to you whether you want to accept the patches or
> not. I think they're useful but I am not going to make a stink about it.

The *rest* of the patch is very useful.  Thank you :)

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no