From owner-cvs-ports@FreeBSD.ORG Sun Jul 24 01:26:06 2011 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 449F5106568D; Sun, 24 Jul 2011 01:26:06 +0000 (UTC) (envelope-from prvs=117900e680=brian@Awfulhak.org) Received: from idcmail-mo1so.shaw.ca (idcmail-mo1so.shaw.ca [24.71.223.10]) by mx1.freebsd.org (Postfix) with ESMTP id C2A0F8FC1B; Sun, 24 Jul 2011 01:26:05 +0000 (UTC) Received: from pd3ml3so-ssvc.prod.shaw.ca ([10.0.141.149]) by pd4mo1so-svcs.prod.shaw.ca with ESMTP; 23 Jul 2011 19:11:03 -0600 X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=uT3SUsFrUxSLMLkvWEyF5PJ45gYvcyNzEdQWRoVmi+I= c=1 sm=1 a=wom5GMh1gUkA:10 a=aj_v5Yfd6UsA:10 a=dBRESv0yCI8A:10 a=BLceEmwcHowA:10 a=kj9zAlcOel0A:10 a=cmB/9TsswV7PJ0tytqGp1Q==:17 a=tZ5SSJdqAAAA:8 a=MMwg4So0AAAA:8 a=6I5d2MoRAAAA:8 a=4DvDO3B-bXB4Q7GF9t4A:9 a=5SKc6MwKRXml56gWwnUA:7 a=CjuIK1q_8ugA:10 a=WJ3hkfHDukgA:10 a=SV7veod9ZcQA:10 a=HpAAvcLHHh0Zw7uRqdWCyQ==:117 Received: from unknown (HELO store.lan.Awfulhak.org) ([70.79.183.1]) by pd3ml3so-dmz.prod.shaw.ca with ESMTP; 23 Jul 2011 19:11:03 -0600 Received: from store.lan.Awfulhak.org (localhost.localdomain [127.0.0.1]) by localhost (Email Security Appliance) with SMTP id 7F071C433EB_E2B694FB; Sun, 24 Jul 2011 00:37:35 +0000 (GMT) Received: from gw.Awfulhak.org (gw.lan.Awfulhak.org [172.16.0.1]) by store.lan.Awfulhak.org (Sophos Email Appliance) with ESMTP id 8451BC460FB_E2B694EF; Sun, 24 Jul 2011 00:37:34 +0000 (GMT) Received: from thong.lan.Awfulhak.org (thong.lan.Awfulhak.org [172.16.0.31]) by gw.Awfulhak.org (8.14.5/8.14.5) with ESMTP id p6O0aXZ5083253; Sat, 23 Jul 2011 17:36:33 -0700 (PDT) (envelope-from brian@lan.Awfulhak.org) Received: from thong.lan.Awfulhak.org (localhost [127.0.0.1]) by thong.lan.Awfulhak.org (8.14.5/8.14.5) with ESMTP id p6O0aXJo026585; Sat, 23 Jul 2011 17:36:33 -0700 (PDT) (envelope-from brian@thong.lan.Awfulhak.org) Received: (from brian@localhost) by thong.lan.Awfulhak.org (8.14.5/8.14.5/Submit) id p6O0aWkR026562; Sat, 23 Jul 2011 17:36:32 -0700 (PDT) (envelope-from brian) Date: Sat, 23 Jul 2011 17:36:32 -0700 From: Brian Somers To: Doug Barton Message-ID: <20110724003632.GA3604@thong.lan.Awfulhak.org> References: <201107200252.p6K2qZRb053515@repoman.freebsd.org> <4E2B2B82.1020506@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E2B2B82.1020506@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: "b. f." , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, riggs@rrr.de, bf1783@gmail.com, cvs-ports@FreeBSD.org, Mario Sergio Fujikawa Ferreira Subject: Re: cvs commit: ports/multimedia/mencoder Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Jul 2011 01:26:06 -0000 On Sat, Jul 23, 2011 at 01:13:54PM -0700, Doug Barton wrote: > On 07/22/2011 23:07, b. f. wrote: > > > I must renew my plea to avoid these "fixes". When a user sets > > WITH/WITHOUT_FOO, he means precisely "build this port > > WITH/WITHOUT_FOO", and not "build this port WITH/WITHOUT_FOO, except > > if package X is installed, and, if it is, silently do something else", > > and we should not be adding code to do the latter. We should instead > > patch the broken distribution configure scripts and Makefiles, so that > > the problem does not occur. If a lack of time or another problem > > prevents this from being done initially, then as a temporary > > workaround, we should add something like: > > > > .if exists(${LOCALBASE}/lib/libass.so) && defined(WITHOUT_ASS) > > BROKEN= libass is installed, so broken mplayer scripts will ignore WITHOUT_ASS > > .endif > > > > so that the user will know that his choice of options cannot be used, > > and he can take the appropriate action -- and he will not be misled > > into thinking that his choice of options are used when they are not. > > +1 > > -- > > Nothin' ever doesn't change, but nothin' changes much. > -- OK Go > > Breadth of IT experience, and depth of knowledge in the DNS. > Yours for the right price. :) http://SupersetSolutions.com/ > Agreed. Any code that changes behaviour based on what's installed is broken as it alters its output across multiple runs. Specifically, a super-port that just depends on a whole bunch of other ports can get into a lot of trouble when you "make && sudo make package" as the packaging stage of each component port may have requirements that weren't met during the first make. -- Brian Somers Don't _EVER_ lose your sense of humour !