Date: Tue, 11 Oct 2011 12:40:11 GMT From: Ed Schouten <ed@80386.nl> To: freebsd-x11@FreeBSD.org Subject: Re: ports/161480: [patch] x11/luit: don't depend on pty(4), use openpty(3) Message-ID: <201110111240.p9BCeBID090414@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/161480; it has been noted by GNATS. From: Ed Schouten <ed@80386.nl> To: bug-followup@FreeBSD.org, nalitoja@gmail.com Cc: bf1783@gmail.com Subject: Re: ports/161480: [patch] x11/luit: don't depend on pty(4), use openpty(3) Date: Tue, 11 Oct 2011 14:32:37 +0200 Hi, I'd rather see something like the attached patch get committed upstream. There's nothing wrong with using grantpt(), it's just the lack of a call to posix_openpt(2). diff --git a/configure.ac b/configure.ac index c3cd947..e9a5984 100644 --- a/configure.ac +++ b/configure.ac @@ -38,7 +38,7 @@ AC_CANONICAL_HOST AC_CHECK_HEADERS([pty.h stropts.h sys/param.h sys/select.h]) -AC_CHECK_FUNCS([select grantpt]) +AC_CHECK_FUNCS([select grantpt posix_openpt]) AC_ARG_WITH(localealiasfile, AS_HELP_STRING([--with-localealiasfile=<path>], diff --git a/sys.c b/sys.c index 804bdbb..8463b05 100644 --- a/sys.c +++ b/sys.c @@ -335,7 +335,11 @@ allocatePty(int *pty_return, char **line_return) #if defined(HAVE_GRANTPT) int rc; +#ifdef HAVE_POSIX_OPENPT + pty = posix_openpt(O_RDWR); +#else pty = open("/dev/ptmx", O_RDWR); +#endif if (pty < 0) goto bsd; Greetings, -- Ed Schouten <ed@80386.nl> WWW: http://80386.nl/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201110111240.p9BCeBID090414>