From owner-freebsd-bugs  Mon Jun 17 14:40:19 2002
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id C51D437B419
	for <freebsd-bugs@hub.freebsd.org>; Mon, 17 Jun 2002 14:40:05 -0700 (PDT)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g5HLe5837345;
	Mon, 17 Jun 2002 14:40:05 -0700 (PDT)
	(envelope-from gnats)
Received: from nwww.freebsd.org (www.FreeBSD.org [216.136.204.117])
	by hub.freebsd.org (Postfix) with ESMTP id E07F037B428
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 17 Jun 2002 14:37:16 -0700 (PDT)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by nwww.freebsd.org (8.12.2/8.12.2) with ESMTP id g5HLbGhG067282
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 17 Jun 2002 14:37:16 -0700 (PDT)
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.2/8.12.2/Submit) id g5HLbG1q067279;
	Mon, 17 Jun 2002 14:37:16 -0700 (PDT)
Message-Id: <200206172137.g5HLbG1q067279@www.freebsd.org>
Date: Mon, 17 Jun 2002 14:37:16 -0700 (PDT)
From: Dave Earp <morbiddk@insensible.net>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-1.0
Subject: kern/39442: double define in ng_pppoe.c
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org


>Number:         39442
>Category:       kern
>Synopsis:       double define in ng_pppoe.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 17 14:40:05 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Dave Earp
>Release:        4.6
>Organization:
N/A
>Environment:
FreeBSD limpid 4.6-RELEASE FreeBSD 4.6-RELEASE #0: Tue Jun 11 06:14:12 GMT 2002
murray@builder.freebsdmall.com:/usr/src/sys/compile/GENERIC  i386
>Description:
There appears to be a double define of the send_sessionid variable in netgraph/ng_pppoe.c for 4.6-STABLE

The following is defined two times in a row beginning line 841:

static int
send_sessionid(sessp sp)
{
        int error;
        struct ng_mesg *msg;

        NG_MKMESSAGE(msg, NGM_PPPOE_COOKIE, NGM_PPPOE_SESSIONID,
            sizeof(u_int16_t), M_NOWAIT);
        if (msg == NULL) 
                return (ENOMEM);

        *(u_int16_t *)msg->data = sp->Session_ID; 
        error = ng_send_msg(sp->hook->node, msg, sp->creator, NULL);

        return (error);
}

This results in a build error when building the -STABLE kernel
>How-To-Repeat:

>Fix:
Removed one define of the variable fixed this issue for me.
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message