From owner-cvs-all@FreeBSD.ORG  Mon Jul 21 14:51:54 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id BD2BE37B407
	for <cvs-all@FreeBSD.org>; Mon, 21 Jul 2003 14:51:54 -0700 (PDT)
Received: from rootlabs.com (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 6B84743FBD
	for <cvs-all@FreeBSD.org>; Mon, 21 Jul 2003 14:51:53 -0700 (PDT)
	(envelope-from nate@rootlabs.com)
Received: (qmail 34925 invoked by uid 1000); 21 Jul 2003 21:51:54 -0000
Date: Mon, 21 Jul 2003 14:51:54 -0700 (PDT)
From: Nate Lawson <nate@root.org>
To: Peter Wemm <peter@FreeBSD.org>
In-Reply-To: <20030721205935.A843937B488@hub.freebsd.org>
Message-ID: <20030721144902.R34834@root.org>
References: <20030721205935.A843937B488@hub.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/i386/acpica acpi_wakeup.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Jul 2003 21:51:55 -0000

On Mon, 21 Jul 2003, Peter Wemm wrote:
>   Modified files:
>     sys/i386/acpica      acpi_wakeup.c
>   Log:
>   Commit Ian Dowse's workaround for acpi resume resetting after the
>   LAZY_SWITCH changes.  He pointed out the acpi code sets up an identity
>   mapping in the current vmspace and that got messed up by the %cr3 being
>   out of sync with the current page directory.  As a workaround, restore
>   %cr3 across the sleep/resume.  A more complete fix would be to undo the
>   lazy state and clear the pm_active bit from the borrowed pmap, but this
>   works and people are currently hurting.  I'll clean this up.
>   This is mostly Ian's patch, plus a PAE tweak from me.

Thank you for following up on this.  As I asked on the Usenix conf. call,
are there any other registers that are being missed in the save/restore?
There are some other aging code in this wakeup code that may not fit with
our changing register models.

-Nate