From owner-svn-src-stable@freebsd.org Thu Nov 21 19:07:58 2019 Return-Path: Delivered-To: svn-src-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 44DAB1C82DE; Thu, 21 Nov 2019 19:07:58 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from springbank.echomania.com (springbank.echomania.com [IPv6:2a01:7c8:aab2:81::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "springbank.echomania.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47Jpws67rZz3JZJ; Thu, 21 Nov 2019 19:07:57 +0000 (UTC) (envelope-from dim@FreeBSD.org) X-Virus-Scanned: Debian amavisd-new at springbank.echomania.com Received: from [IPv6:2001:470:7a58::a9b6:ac6d:ea45:224e] (unknown [IPv6:2001:470:7a58:0:a9b6:ac6d:ea45:224e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by springbank.echomania.com (Postfix) with ESMTPSA id 1671D580227; Thu, 21 Nov 2019 20:07:53 +0100 (CET) From: Dimitry Andric Message-Id: Content-Type: multipart/signed; boundary="Apple-Mail=_C13C8E61-27C0-4564-B130-AA556F53A5A2"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: svn commit: r354803 - in stable: 11/contrib/llvm/lib/Transforms/InstCombine 12/contrib/llvm/lib/Transforms/InstCombine Date: Thu, 21 Nov 2019 20:07:46 +0100 In-Reply-To: Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org To: Ronald Klop References: <201911180704.xAI74xAM039993@repo.freebsd.org> X-Mailer: Apple Mail (2.3445.104.11) X-Rspamd-Queue-Id: 47Jpws67rZz3JZJ X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.36 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-0.83)[-0.831,0]; NEURAL_HAM_LONG(-0.53)[-0.534,0]; ASN(0.00)[asn:20857, ipnet:2a01:7c8::/32, country:NL] X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2019 19:07:58 -0000 --Apple-Mail=_C13C8E61-27C0-4564-B130-AA556F53A5A2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 21 Nov 2019, at 16:06, Ronald Klop wrote: >=20 > On Mon, 18 Nov 2019 08:04:59 +0100, Dimitry Andric = wrote: >> Author: dim >> Date: Mon Nov 18 07:04:59 2019 >> New Revision: 354803 >> URL: https://svnweb.freebsd.org/changeset/base/354803 >>=20 >> Log: >> MFC r354724: >> Merge commit 5bbb604bb from llvm git (by Craig Topper): >> [InstCombine] Disable some portions of foldGEPICmp for GEPs that >> return a vector of pointers. Fix other portions. >> llvm-svn: 370114 >> This should fix instances of 'Assertion failed: (isa(Val) && >> "cast() argument of incompatible type!"), function cast, file >> /usr/src/contrib/llvm/include/llvm/Support/Casting.h, line 255', = when >> building openjdk8 for aarch64 and armv7. >> Reported by: jbeich >> PR: 236566 >>=20 >=20 >=20 > Are there plans for an errata notice for releng-12.1 with this fix? = That would keep Openjdk8 as a pkg on aarch64 after 12.0 goes EOL and = pkgs will be build on 12.1. There should be no need for this, as release versions (and stable branches) have their copies of clang compiled with assertions disabled. Hence, the assertion reported in PR 236566 cannot occur, unless you have explicitly turned them on again and recompiled the toolchain components. I have tried compiling the original test case from the PR on both 12.0-RELEASE and 12.1-RELEASE. On 12.0-RELEASE, which has clang version 6.0.1 (tags/RELEASE_601/final 335540), it complains that the -fno-delete-null-pointer-checks and -faddrsig options are unknown, but this is to be expected. The former was important to get the original assertion. If I remove both those options, the test case compiles just fine. On 12.1-RELEASE, which has clang version 8.0.1 (tags/RELEASE_801/final 366581), the test case compiles just fine, out of the box. -Dimitry --Apple-Mail=_C13C8E61-27C0-4564-B130-AA556F53A5A2 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCXdbgggAKCRCwXqMKLiCW o04+AJ9U33dfByow9sRNWHImOn178dgYDgCeO5atGS85s+g4Uq9p/Mk4fTqEnvs= =w6wk -----END PGP SIGNATURE----- --Apple-Mail=_C13C8E61-27C0-4564-B130-AA556F53A5A2--