Date: Mon, 4 Sep 2023 21:05:15 +0200 From: Felix Palmen <zirias@freebsd.org> To: freebsd-current@freebsd.org, current@freebsd.org Subject: Re: Possible issue with linux xattr support? Message-ID: <tzr2ymwukcjld6ym2wcrqwsog6cbzgap65naslr33fib6ovwv5@lrgc6pex2ome> In-Reply-To: <ZPYm1x71N2cTJKDw@heemeyer.club> References: <ZO8KaKBwliVeGdVG@heemeyer.club> <l5vgnwjddobhl5h2vceafhdo5uyqznaih7se7rk7bilwzqjpax@5ucptcralggq> <ZO8ea5sXCEKYimr1@heemeyer.club> <hwugmejws4sihu2gi4ccqi34cplyq6dfctkhkb6crnuivz65pz@sbr6og3znxlv> <ZO8iWGOWcM9x8FOR@heemeyer.club> <xehacpkc3uc3cjgkybj26snod2d76hfuoz2qnhsjectxtojvhx@ytzoek66ksz5> <52go6mhpf34em7x7llzh7dgtf7ggdd7n2wuofm2yrndiw73yqk@pgngyvdypvhd> <ZPYiGN1__7rKo2lt@heemeyer.club> <hmixz6dxasfjhmdc2b7ckxpo2phfzwczlwvlhqhwmdhob65pal@bkmimfxfwvio> <ZPYm1x71N2cTJKDw@heemeyer.club>
next in thread | previous in thread | raw e-mail | index | archive | help
--7sg762hlmw5sgmou
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
* Dmitry Chagin <dchagin@freebsd.org> [20230904 21:49]:
> On Mon, Sep 04, 2023 at 08:43:02PM +0200, Felix Palmen wrote:
> > Thanks a lot for the quick patch! I have to admit I don't fully
> > understand it immediately, but I assume it's an attempt to only list
> > attributes not in system.* when that namespace is restricted?
>=20
> no,
> + if (error =3D=3D EPERM)
> + break;
> mean that listxattr will fail if user is unauthorized to access system
> namespace, ie, listxattr will return ENOTSUP
Ah, now I get it, so breaking out of the loop there will leave
attrnamespace at EXTATTR_NAMESPACE_SYSTEM if that was the cause,
therefore error_to_xattrerror() works as expected. Nice!
Well, given that I really don't expect any further problems, but give my
poor builder a few hours to *really* verify :)
Cheers, Felix
--=20
Felix Palmen <zirias@FreeBSD.org> {private} felix@palmen-it.de
-- ports committer -- {web} http://palmen-it.de
{pgp public key} http://palmen-it.de/pub.txt
{pgp fingerprint} 6936 13D5 5BBF 4837 B212 3ACC 54AD E006 9879 F231
--7sg762hlmw5sgmou
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iNUEABYKAH0WIQRpNhPVW79IN7ISOsxUreAGmHnyMQUCZPYqa18UgAAAAAAuAChp
c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0Njkz
NjEzRDU1QkJGNDgzN0IyMTIzQUNDNTRBREUwMDY5ODc5RjIzMQAKCRBUreAGmHny
MTbKAQDKJp2XWwFxntwsV2HDTErZnwx03qu78jWsCG+LH/48AgEA6LD5eH9MD8dC
06n5WR6l1ox556TtpsSbSuUt7p8qEw8=
=jei9
-----END PGP SIGNATURE-----
--7sg762hlmw5sgmou--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?tzr2ymwukcjld6ym2wcrqwsog6cbzgap65naslr33fib6ovwv5>