From owner-freebsd-current@freebsd.org Thu May 6 10:07:04 2021 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 927DA5FA0CC for ; Thu, 6 May 2021 10:07:04 +0000 (UTC) (envelope-from yuripv@FreeBSD.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4FbTlD3hZ7z4WBG for ; Thu, 6 May 2021 10:07:04 +0000 (UTC) (envelope-from yuripv@FreeBSD.org) Received: by mailman.nyi.freebsd.org (Postfix) id 7E9175FA061; Thu, 6 May 2021 10:07:04 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7B43E5FA2A5 for ; Thu, 6 May 2021 10:07:04 +0000 (UTC) (envelope-from yuripv@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FbTlD35zhz4WDl; Thu, 6 May 2021 10:07:04 +0000 (UTC) (envelope-from yuripv@FreeBSD.org) Received: from [192.168.1.12] (unknown [91.240.124.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: yuripv) by smtp.freebsd.org (Postfix) with ESMTPSA id 889CA28789; Thu, 6 May 2021 10:07:03 +0000 (UTC) (envelope-from yuripv@FreeBSD.org) Subject: Re: linking to git revisions in bugzilla To: Oleksandr Tymoshenko , Kubilay Kocak Cc: current@freebsd.org, Bugmeister References: <134b5580-360a-43c9-8c8f-2a50c2524e7e@www.fastmail.com> <36286647-e005-d289-45d6-9630d39d6430@FreeBSD.org> <20210502050310.GA4428@bluezbox.com> From: Yuri Pankov Message-ID: <267d6951-570f-43c7-ddf2-fa794362bfef@FreeBSD.org> Date: Thu, 6 May 2021 13:07:01 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210502050310.GA4428@bluezbox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 May 2021 10:07:04 -0000 Oleksandr Tymoshenko wrote: > Kubilay Kocak (koobs@FreeBSD.org) wrote: >> On 12/04/2021 9:02 am, Yuri Pankov wrote: >>> While filing a bug, I noticed that the help only mentions svn revision numbers, and "Preview" tab had no output when I tried putting "base ", so I'm wondering how do you link to git revisions? >> >> We'll (bugmeister) be adding parsing support for it (along with a few >> other related auto-linking things) >> >> I'd encourage people to use " " (repo = src|doc|ports) >> where short hash is at least 8 chars in the meantime. Once parsing is >> added all previous references will be linked. > > Links to git hashes should work now, please test and let us > know if feature works as expected. As Michael mentioned - preview > is a different matter, I'll try to look into it later. Hi Oleksandr, It seems to work except when the git hash starts with a digit, it then tries to link to subversion revision using all available digits at the start of the hash. Or, at least, that's what I'm seeing in preview tab, not sure if it has been fixed yet?