From owner-freebsd-current  Wed Mar  6 21:34:30 2002
Delivered-To: freebsd-current@freebsd.org
Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8F71037B429; Wed,  6 Mar 2002 21:34:17 -0800 (PST)
Received: (from dillon@localhost)
	by apollo.backplane.com (8.11.6/8.9.1) id g275Xii64069;
	Wed, 6 Mar 2002 21:33:44 -0800 (PST)
	(envelope-from dillon)
Date: Wed, 6 Mar 2002 21:33:44 -0800 (PST)
From: Matthew Dillon <dillon@apollo.backplane.com>
Message-Id: <200203070533.g275Xii64069@apollo.backplane.com>
To: "Justin T. Gibbs" <gibbs@scsiguy.com>
Cc: John Baldwin <jhb@FreeBSD.ORG>, Bruce Evans <bde@zeta.org.au>,
	Terry Lambert <tlambert2@mindspring.com>,
	Alfred Perlstein <alfred@FreeBSD.ORG>,
	Bosko Milekic <bmilekic@unixdaemons.com>,
	Seigo Tanimura <tanimura@r.dl.itc.u-tokyo.ac.jp>,
	FreeBSD current users <current@FreeBSD.ORG>,
	Julian Elischer <julian@elischer.org>
Subject: Re: Patch for critical_enter()/critical_exit() & interrupt assem 
References:  <200203070429.g274TlI51515@aslan.scsiguy.com>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

:My 2 cents?  Work with John to get the APIs that affect this particular
:code stable.  That means discussion and perhaps that discussion will
:take some time (if this blow-up hadn't occurred the discussion
:would already be over now ;-).  Once the APIs are in place, commit your
:code in a format that makes it completely optional, just like your Giant
:lock optimizations.  This means that those interested in validating
:and determining the impact of your code can easily do so by flipping
:a switch.  Those who would rather debug their own subsystem problems
:in a slower, but simpler, environment can do so too.
:
:--
:Justin

    The API is intended for the stage-2 commit.  The stage-1 commit
    is intended to do all the 'hard stuff' in as straightforward
    a manner as possible.  The sysctl / option you talk about here
    existed in my patch set 2 and a half weeks ago.

    I really wish you people would at least read the patch and commit
    message before you comment on it.

						-Matt


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message