From owner-svn-src-head@freebsd.org  Mon Apr  9 19:52:46 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3A78DF9E294;
 Mon,  9 Apr 2018 19:52:46 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D343E6EB81;
 Mon,  9 Apr 2018 19:52:45 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from ralph.baldwin.cx (ralph.baldwin.cx [66.234.199.215])
 by mail.baldwin.cx (Postfix) with ESMTPSA id 042CA10AFAD;
 Mon,  9 Apr 2018 15:52:45 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Warner Losh <imp@bsdimp.com>
Cc: Ed Maste <emaste@freebsd.org>, src-committers <src-committers@freebsd.org>,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r332090 - head/stand/i386
Date: Mon, 09 Apr 2018 12:28:47 -0700
Message-ID: <3188731.iHBUE9bOzj@ralph.baldwin.cx>
User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; )
In-Reply-To: <CANCZdfoJUS14gvSDNch+_bdwyVrAHPRZW73LtzWQXyPOOV64Rg@mail.gmail.com>
References: <201804060257.w362vwi3023158@repo.freebsd.org>
 <CAPyFy2CKa1nit1B15FTjGYEME0ya5CxLNwH44Xwz_QaM9Rsy7A@mail.gmail.com>
 <CANCZdfoJUS14gvSDNch+_bdwyVrAHPRZW73LtzWQXyPOOV64Rg@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (mail.baldwin.cx); Mon, 09 Apr 2018 15:52:45 -0400 (EDT)
X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx
X-Virus-Status: Clean
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Apr 2018 19:52:46 -0000

On Monday, April 09, 2018 11:02:01 AM Warner Losh wrote:
> On Mon, Apr 9, 2018 at 10:44 AM, Ed Maste <emaste@freebsd.org> wrote:
> 
> > On 6 April 2018 at 13:54, John Baldwin <jhb@freebsd.org> wrote:
> > > On Friday, April 06, 2018 02:57:58 AM Ed Maste wrote:
> > >> Author: emaste
> > >> Date: Fri Apr  6 02:57:58 2018
> > >> New Revision: 332090
> > >> URL: https://svnweb.freebsd.org/changeset/base/332090
> > >>
> > >> Log:
> > >>   stand: pass --no-rosegment for i386 bits when linking with lld
> > >>
> > >
> > > Maybe we should support LDFLAGS.${LINKER_TYPE} as we do for CFLAGS, etc.?
> >
> > I don't anticipate LINKER_TYPE tests proliferating, but a good point
> > nonetheless. Change proposed in review D14998.
> >
> 
> We only really support two compilers. This lets us have fewer .if
> statements which historically people have messed often enough that we've
> move to constructs that avoid them.

I do think we are likely to have far fewer conditional LDFLAGS rather
than CFLAGS though.  I think if we are only going to have 1 or 2
instances in the tree then LDFLAGS.LINKER_TYPE might perhaps be
overkill, but if we think there will be several then I think it is
more readable.

-- 
John Baldwin