From owner-svn-src-all@freebsd.org Mon Nov 11 10:30:41 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 23E291B1AD3; Mon, 11 Nov 2019 10:30:41 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47BRwd0BGcz41lQ; Mon, 11 Nov 2019 10:30:40 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: by mail-qk1-f194.google.com with SMTP id z16so10703948qkg.7; Mon, 11 Nov 2019 02:30:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LDMDsW8RtfaSJGK6YnL4Hi3cA6dnJOeSpggXlzX+u1c=; b=IAfYJ1NVxmBgIEfP5Bk2ukm/WELiheW7I0eIo2T+KNHLKc07sAOM0eOy3acR1cl459 /zV8eStJVKrMVstI7i+fSk5Kc25FpIEnpN7J5cF5r6oup517KcVWNUx2eup32c16HbPX 9QhMC+9jTu4t2hIOSNWJ3VKjOb+kv18VMc2ABwBBWp95zLMgNVjruPxUQR6CXyD0msEr n1KFhQpnjcW9IKetB4qz9w4cnoGvVC0X9vUw4xLUDT5/4DIJdxmOfsAk36RS3b71XK34 QBEQAUzqjVe9W4aQ8qpL9dillTuEOZRTE1mrBmuRr+Fj1yuKIj36yiJyY1g4Pcez9/mx IE4g== X-Gm-Message-State: APjAAAUHMS+Ji/TRluI/3B0wWIKmU5iC1tFXfL9jmfUUm4/217pqTFVN LOBsozT4yIB28+YXpZ3nmr/Wfx9ZzhIbraani1ux5vd3 X-Google-Smtp-Source: APXvYqxrP1GUuqyb06DyOCexcVc8gogUvm3RdkdmVwNR+NsMHqk0Q/4BSrxMkQbocsFk9lCjc50Lk9qy6oyRQqk/J38= X-Received: by 2002:a37:b885:: with SMTP id i127mr5286075qkf.485.1573468239376; Mon, 11 Nov 2019 02:30:39 -0800 (PST) MIME-Version: 1.0 References: <201911101841.xAAIfEXV088995@repo.freebsd.org> <4FEA5BCC-A9E7-4FDB-8392-04027239D9B0@FreeBSD.org> In-Reply-To: <4FEA5BCC-A9E7-4FDB-8392-04027239D9B0@FreeBSD.org> From: Antoine Brodin Date: Mon, 11 Nov 2019 11:30:27 +0100 Message-ID: Subject: Re: svn commit: r354598 - in stable: 11/contrib/libc++/include 11/sys/sys 12/contrib/libc++/include 12/sys/sys To: Dimitry Andric Cc: src-committers , svn-src-all , svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 47BRwd0BGcz41lQ X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Nov 2019 10:30:41 -0000 On Mon, Nov 11, 2019 at 11:10 AM Dimitry Andric wrote: > > On 11 Nov 2019, at 10:29, Antoine Brodin wrote: > > > > On Mon, Nov 11, 2019 at 9:03 AM Antoine Brodin wrote: > >> > >> On Sun, Nov 10, 2019 at 7:41 PM Dimitry Andric wrote: > >>> > >>> Author: dim > >>> Date: Sun Nov 10 18:41:13 2019 > >>> New Revision: 354598 > >>> URL: https://svnweb.freebsd.org/changeset/base/354598 > >>> > >>> Log: > >>> MFC r354460: > >>> > >>> Merge commit e8316372b from llvm git (by Louis Dionne): > >>> > >>> [libc++] Add `__truncating_cast` for safely casting float types to > >>> integers > >>> > >>> This is needed anytime we need to clamp an arbitrary floating point > >>> value to an integer type. > >>> > >>> Thanks to Eric Fiselier for the patch. > >>> > >>> Differential Revision: https://reviews.llvm.org/D66836 > >>> > >>> llvm-svn: 370891 > >>> > >>> Merge commit b92deded8 from llvm git (by Louis Dionne): > >>> > >>> [libc++] Move __clamp_to_integral to , and harden against > >>> min()/max() macros > >>> > >>> llvm-svn: 370900 > >>> > >>> Merge commit 0ec6a4882 from llvm git (by Louis Dionne): > >>> > >>> [libc++] Fix potential OOB in poisson_distribution > >>> > >>> See details in the original Chromium bug report: > >>> https://bugs.chromium.org/p/chromium/issues/detail?id=994957 > >>> > >>> Together, these fix a security issue in libc++'s implementation of > >>> std::poisson_distribution, which can be exploited to read data which is > >>> out of bounds. > >>> > >>> Note there are no programs in the FreeBSD base system that use > >>> std::poisson_distribution, so this is only a possible issue for ports > >>> and external programs which have been built against libc++. Therefore, > >>> I am bumping __FreeBSD_version for the benefit of our port maintainers. > >>> > >>> Requested by: emaste > >>> Security: potential OOB read > >>> > >>> Modified: > >>> stable/11/contrib/libc++/include/cmath > >>> stable/11/contrib/libc++/include/random > >>> stable/11/sys/sys/param.h > >>> Directory Properties: > >>> stable/11/ (props changed) > >>> > >>> Changes in other areas also in this revision: > >>> Modified: > >>> stable/12/contrib/libc++/include/cmath > >>> stable/12/contrib/libc++/include/random > >>> stable/12/sys/sys/param.h > >>> Directory Properties: > >>> stable/12/ (props changed) > >> > >> Hi, > >> > >> It seems that some recent changes to stable/11 are broken, lots of > >> ports now fail to build on stable/11. > > > > This affects stable/12 too. > > It seems that the cmath header can't be compiled. > > Interesting, it works fine here on e.g. stable/12: > > $ cat test-cmath.cpp > #include > > $ c++ -c test-cmath.cpp > > Are there any build logs available showing errors? For instance these logs: http://gohan01.nyi.freebsd.org/data/12stable-i386-quarterly-baseline/517228/logs/errors/x265-3.1.2_2.log http://gohan01.nyi.freebsd.org/data/12stable-i386-quarterly-baseline/517228/logs/errors/exiv2-0.27.1_2,1.log /usr/include/c++/v1/cmath:622:68: error: too many arguments provided to function-like macro invocation static_assert(is_same<_FloatT, float>::value || is_same<_FloatT, double>::value ^ /usr/include/c++/v1/__config:873:13: note: macro 'static_assert' defined here # define static_assert(__b, __m) _Static_assert(__b, __m) ^ Antoine