From owner-freebsd-current@FreeBSD.ORG Tue Sep 6 13:32:30 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 07BA516A420; Tue, 6 Sep 2005 13:32:30 +0000 (GMT) (envelope-from rodrigc@crodrigues.org) Received: from rwcrmhc12.comcast.net (rwcrmhc12.comcast.net [204.127.198.43]) by mx1.FreeBSD.org (Postfix) with ESMTP id F0D5243D45; Tue, 6 Sep 2005 13:32:27 +0000 (GMT) (envelope-from rodrigc@crodrigues.org) Received: from c-66-30-115-133.hsd1.ma.comcast.net ([66.30.115.133]) by comcast.net (rwcrmhc12) with ESMTP id <2005090613322301400aohu4e>; Tue, 6 Sep 2005 13:32:24 +0000 Received: from c-66-30-115-133.hsd1.ma.comcast.net (localhost.127.in-addr.arpa [127.0.0.1]) by c-66-30-115-133.hsd1.ma.comcast.net (8.13.4/8.13.1) with ESMTP id j86DWM3r000971; Tue, 6 Sep 2005 09:32:22 -0400 (EDT) (envelope-from rodrigc@c-66-30-115-133.hsd1.ma.comcast.net) Received: (from rodrigc@localhost) by c-66-30-115-133.hsd1.ma.comcast.net (8.13.4/8.13.1/Submit) id j86DWLtW000970; Tue, 6 Sep 2005 09:32:21 -0400 (EDT) (envelope-from rodrigc) Date: Tue, 6 Sep 2005 09:32:21 -0400 From: Craig Rodrigues To: Giorgos Keramidas Message-ID: <20050906133221.GA903@crodrigues.org> References: <20050903133344.GA633@gothmog.gr> <20050905162713.GA92142@crodrigues.org> <20050905175826.GL69481@zxy.spb.ru> <20050906015418.GA590@gothmog.gr> <20050906120809.GP69481@zxy.spb.ru> <20050906124508.GA27413@orion.daedalusnetworks.priv> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050906124508.GA27413@orion.daedalusnetworks.priv> User-Agent: Mutt/1.5.9i Cc: rodrigc@freebsd.org, freebsd-current@freebsd.org, mirya@matrix.kiev.ua, Slawa Olhovchenkov Subject: Re: moused related panic X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Sep 2005 13:32:30 -0000 On Tue, Sep 06, 2005 at 03:45:08PM +0300, Giorgos Keramidas wrote: > I don't really like the "hackish" way my last patch avoids the panics, because > assuming that a default font_width of 8 is ok is probably one gratuitous > assumption too many. I haven't had a chance to look at the font changing > implementation to see if scp->font_width can be set elsewhere to a non-zero > value or if it's supposed to be zero in text modes. Can you try this: Index: scvidctl.c =================================================================== RCS file: /home/ncvs/src/sys/dev/syscons/scvidctl.c,v retrieving revision 1.35 diff -u -u -r1.35 scvidctl.c --- scvidctl.c 30 Aug 2005 18:58:16 -0000 1.35 +++ scvidctl.c 6 Sep 2005 13:31:30 -0000 @@ -145,6 +145,8 @@ return ENODEV; /* adjust argument values */ + if (fontwidth <= 0) + fontwidth = info.vi_cwidth; if (fontsize <= 0) fontsize = info.vi_cheight; if (fontsize < 14) { -- Craig Rodrigues rodrigc@crodrigues.org