From owner-freebsd-arch Wed May 1 18:27:12 2002 Delivered-To: freebsd-arch@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40]) by hub.freebsd.org (Postfix) with ESMTP id D41F037B416; Wed, 1 May 2002 18:27:04 -0700 (PDT) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.12.1/8.12.1) with ESMTP id g421R2BN048804; Wed, 1 May 2002 21:27:03 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <20020501193212.C9763-100000@mail.chesapeake.net> References: <20020501193212.C9763-100000@mail.chesapeake.net> Date: Wed, 1 May 2002 21:27:01 -0400 To: Jeff Roberson , arch@FreeBSD.ORG From: Garance A Drosihn Subject: Re: Removal of register && K&R function decl. Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: MIMEDefang 2.3 (www dot roaringpenguin dot com slash mimedefang) Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 7:39 PM -0400 5/1/02, Jeff Roberson wrote: >What is the policy on commits soley to remove the register >keyword, as well as ansification of functions? The decision has already been made that ansi-fication of source is a good idea, and many commits have been made along those lines in the last few months. I'm pretty sure the consensus is that it's also a good idea to remove 'register' references, generally done as a separate commit. That way it's a little easier to test that no bugs are introduced by the ansi-fication. >A certain eager contributor would like to do a general sweep >through kern/* to remove these antiquities. However, with all the SMPng and other kernel work going on, it probably would not be a good idea to go running around changing those particular source files. Ansi-fication is a "good thing", but it is not a high-priority change to make. It is not a "good thing" if doing this will disrupt other work which is actively going on in the same source files. You'd need to check on a file-by-file basis to see if anyone's working on it, instead of trying for a general sweep through all the files. Note that I don't work on the kern files, so the above is just my own opinion. -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message