From owner-p4-projects@FreeBSD.ORG Wed Feb 7 11:21:58 2007 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 8294C16A402; Wed, 7 Feb 2007 11:21:34 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 25E1D16A405 for ; Wed, 7 Feb 2007 11:21:30 +0000 (UTC) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 1351013C48D for ; Wed, 7 Feb 2007 11:21:30 +0000 (UTC) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id l17BLTkN050828 for ; Wed, 7 Feb 2007 11:21:29 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id l17BLTQ1050821 for perforce@freebsd.org; Wed, 7 Feb 2007 11:21:29 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Date: Wed, 7 Feb 2007 11:21:29 GMT Message-Id: <200702071121.l17BLTQ1050821@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f From: Robert Watson To: Perforce Change Reviews Cc: Subject: PERFORCE change 114168 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2007 11:21:58 -0000 http://perforce.freebsd.org/chv.cgi?CH=114168 Change 114168 by rwatson@rwatson_cinnamon on 2007/02/07 11:20:57 Move zeroing of *bz outside of locked region since the locks are not required to zero the ioctl argument structure. Affected files ... .. //depot/projects/zcopybpf/src/sys/net/bpf_zerocopy.c#18 edit Differences ... ==== //depot/projects/zcopybpf/src/sys/net/bpf_zerocopy.c#18 (text+ko) ==== @@ -584,8 +584,8 @@ { struct zbuf *bzh; + bzero(bz, sizeof(*bz)); BPFD_LOCK(d); - bzero(bz, sizeof(*bz)); if (d->bd_hbuf == NULL && d->bd_slen != 0) { ROTATE_BUFFERS(d); bzh = (struct zbuf *)d->bd_hbuf;