From owner-svn-src-all@FreeBSD.ORG Tue Jun 24 16:08:16 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 744A6EA for ; Tue, 24 Jun 2014 16:08:16 +0000 (UTC) Received: from mail-qg0-f50.google.com (mail-qg0-f50.google.com [209.85.192.50]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 30E9A2B51 for ; Tue, 24 Jun 2014 16:08:15 +0000 (UTC) Received: by mail-qg0-f50.google.com with SMTP id j5so463566qga.37 for ; Tue, 24 Jun 2014 09:08:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:content-type:mime-version:subject :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=hkPyI64dAFF7P/n325R2w/epzJIhebkGQWSnhH6f0C4=; b=QtUxOgZ/zgNtYb5ZMEKjufA4LQae+FrAzHcDwUTaudYYWCB7USo/IqcRAubbiiqb2I 3ANLEQcDKPTEymS/dH1dhhETU1bch8sYLBkJ5Nx+QBR0OWk21eQoiCcIZH1kSTN7dn6a z9qvKDvz/qQl9hYm+HOXATeh7802AtBVFKFFVVxIKM9zmkUW7RGVy2q8MrgqsEIgxlfS 8GJ3DQlkZFOo53I9Ahws2DrkD1YiNZEqa10nBSWYuepOAx1US84JWvNpLape7Q2h9EbQ BoBUQDrW1eT+IQ3t2g5RM1ihsfMQqyhP9lOqTy8AwRA7tGLxTFKKnuOM0aX0j3iX4JMh sXvQ== X-Gm-Message-State: ALoCoQllYqn2r5sikLjaiHJt3zqJ4P2qz/gSrLqyolEdmHuy9yjYs2bVK78VOeomDagY39Pizn1J X-Received: by 10.224.38.4 with SMTP id z4mr3334707qad.94.1403626089540; Tue, 24 Jun 2014 09:08:09 -0700 (PDT) Received: from [172.19.248.35] ([64.88.227.134]) by mx.google.com with ESMTPSA id y10sm1065699qal.32.2014.06.24.09.08.04 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 24 Jun 2014 09:08:09 -0700 (PDT) Sender: Warner Losh From: Warner Losh X-Google-Original-From: Warner Losh Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) Subject: Re: svn commit: r267758 - head In-Reply-To: <201406230054.s5N0suIA081734@svn.freebsd.org> Date: Tue, 24 Jun 2014 10:07:55 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <256E890F-9564-4741-A5D8-89543381CF2D@gmail.com> References: <201406230054.s5N0suIA081734@svn.freebsd.org> To: "Andrey A. Chernov" X-Mailer: Apple Mail (2.1878.2) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jun 2014 16:08:16 -0000 On Jun 22, 2014, at 6:54 PM, Andrey A. Chernov wrote: > Author: ache > Date: Mon Jun 23 00:54:56 2014 > New Revision: 267758 > URL: http://svnweb.freebsd.org/changeset/base/267758 >=20 > Log: > Change suggestion how to set MAKESYSPATH as broken incremental build > workaround. Magic ".../share/mk" (search directories up to /) > does not work for f.e. /usr/src/gnu/lib/libgcc because the path > inside is starting from /usr/obj hierarchy and ends up in > /usr/share/mk, not in the /usr/src/share/mk where src.opts.mk is. > IMHO proper fixing of incremental build is needed urgently. I don=92t understand how this is even possible. This change is wrong = because it has a bogus path the doesn=92t exist on all systems. I=92m = going to fix that. Agreed on incremental builds, but that is turning out to be harder than = expected. It is broken, but adding broken advise is even worse. Warner > Modified: > head/UPDATING >=20 > Modified: head/UPDATING > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/UPDATING Sun Jun 22 23:40:20 2014 (r267757) > +++ head/UPDATING Mon Jun 23 00:54:56 2014 (r267758) > @@ -67,7 +67,7 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 11 > behavior back, you can .include /etc/src.conf from = /etc/make.conf > (which is still global and isn't changed). This also changes the > behavior of incremental builds inside the tree of individual > - directories. Set MAKESYSPATH to ".../share/mk" to do that. > + directories. Set MAKESYSPATH to "/usr/src/share/mk" to do that. > Although this has survived make universe and some upgrade = scenarios, > other upgrade scenarios may have broken. At least one form of > temporary breakage was fixed with MAKESYSPATH settings for = buildworld >=20